[Monitor] Add Metrics Query library - #42113
Closed
Paul Van Eck (pvaneck) wants to merge 2 commits into
Closed
Conversation
Contributor
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Paul Van Eck (pvaneck)
force-pushed
the
monitor-querymetrics-typespec
branch
3 times, most recently
from
July 22, 2025 00:07
f9c9fe8 to
9f48896
Compare
Paul Van Eck (pvaneck)
marked this pull request as ready for review
July 22, 2025 00:57
Paul Van Eck (pvaneck)
requested review from
Renhe Li (lirenhe),
Laurent Mazuel (lmazuel) and
Yuchao Yan (msyyc)
as code owners
July 22, 2025 00:57
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new TypeSpec-based Azure Monitor Metrics Query library (azure-monitor-querymetrics) to the Azure SDK for Python. The package provides functionality for querying metrics data from multiple Azure resources through the Azure Monitor service.
Key changes:
- New TypeSpec-generated client library for Azure Monitor metrics querying
- Support for both synchronous and asynchronous operations
- Comprehensive test suite with authentication, granularity, and filtering tests
Reviewed Changes
Copilot reviewed 52 out of 52 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/monitor/ci.yml | Adds CI configuration for the new azure-monitor-querymetrics package |
| sdk/monitor/azure-monitor-querymetrics/tsp-location.yaml | TypeSpec configuration pointing to the Monitor.Query.Metrics specification |
| sdk/monitor/azure-monitor-querymetrics/tests/ | Complete test suite including sync/async client tests and test configuration |
| sdk/monitor/azure-monitor-querymetrics/setup.py | Package setup configuration with dependencies and metadata |
| sdk/monitor/azure-monitor-querymetrics/azure/monitor/querymetrics/ | Core client implementation with models, utilities, and generated code |
This adds the TypeSpec-based azure-monitor-querymetrics package. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Paul Van Eck (pvaneck)
force-pushed
the
monitor-querymetrics-typespec
branch
from
July 22, 2025 02:23
9f48896 to
c1e8b3b
Compare
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Laurent Mazuel (lmazuel)
approved these changes
Jul 22, 2025
Laurent Mazuel (lmazuel)
requested changes
Jul 22, 2025
Laurent Mazuel (lmazuel)
left a comment
Laurent Mazuel (lmazuel)
left a comment
Member
There was a problem hiding this comment.
Please don't use _generated
Member
Author
|
Closing in favor of #42174 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the TypeSpec-based
azure-monitor-querymetricspackage.