Sync eng/common directory with azure-sdk-tools for PR 11353 - #42230
Merged
Ben Broderick Phillips (benbp) merged 3 commits intoJul 25, 2025
Merged
Conversation
Azure SDK Bot (azure-sdk)
requested review from
Ben Broderick Phillips (benbp) and
Copilot
and removed request for
Ben Broderick Phillips (benbp)
July 25, 2025 20:41
Azure SDK Bot (azure-sdk)
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with azure-sdk-tools PR #11353, updating PowerShell helper scripts with minor improvements and fixes.
Key changes:
- Fixed shell shebang line to use proper Unix path
- Added directory creation safety check before file operations
- Enhanced output formatting by adding newlines to shell profile modifications
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/scripts/Helpers/AzSdkTool-Helpers.ps1 | Improved shell profile modification by adding newline before path command |
| eng/common/mcp/azure-sdk-mcp.ps1 | Fixed shebang path, added directory creation check, and improved variable naming |
Comments suppressed due to low confidence (1)
eng/common/mcp/azure-sdk-mcp.ps1:68
- [nitpick] The variable name
$exeDestinationis inconsistent with the existing pattern. Consider using$exeas it was originally named, since this is the primary executable path used throughout the script.
$exeDestination = Join-Path $toolInstallDirectory $exeName
Ben Broderick Phillips (benbp)
approved these changes
Jul 25, 2025
Ben Broderick Phillips (benbp)
deleted the
sync-eng/common-benbp/copilot-install-mac-fixes-11353
branch
July 25, 2025 21:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#11353 See eng/common workflow