Skip to content

Use pkg_resources to parse requirements - #6158

Merged
bsiegel merged 1 commit into
Azure:masterfrom
bsiegel:analyze_script_fix_parse
Jun 28, 2019
Merged

Use pkg_resources to parse requirements#6158
bsiegel merged 1 commit into
Azure:masterfrom
bsiegel:analyze_script_fix_parse

Conversation

@bsiegel

@bsiegel bsiegel commented Jun 27, 2019

Copy link
Copy Markdown
Member

Fixes #6153

@adxsdk6

adxsdk6 commented Jun 27, 2019

Copy link
Copy Markdown

Can one of the admins verify this patch?

@bsiegel

bsiegel commented Jun 27, 2019

Copy link
Copy Markdown
Member Author

/azp run python - identity - ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@bsiegel
bsiegel force-pushed the analyze_script_fix_parse branch from 2aaa79d to f8d0e58 Compare June 27, 2019 23:52
Comment thread scripts/analyze_deps.py
import glob
import io
import os
from pkg_resources import Requirement

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is awesome. setuptools is legit

@bsiegel
bsiegel merged commit 4de5cc7 into Azure:master Jun 28, 2019
@bsiegel
bsiegel deleted the analyze_script_fix_parse branch June 28, 2019 19:16
rajivnandivada pushed a commit to rajivnandivada/azure-sdk-for-python that referenced this pull request Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

analyze_deps doesn't consider version semantics

3 participants