Use HttpLoggingPolicy#8056
Merged
Merged
Conversation
chlowell
added
KeyVault
Client
|
Can one of the admins verify this patch? |
Member
johanste
self-requested a review
October 19, 2019 01:08
chlowell
force-pushed
the
logging-policy
branch
from
October 21, 2019 16:46
7159ac8 to
2ab7f49
Compare
Member
|
Might need this to get CI happy: #8083 |
Member
|
@chlowell please use this opportunity to update minimal dependency of identy and keyvault-xxx to core 1.0.0b5 |
chlowell
requested review from
danieljurek,
mitchdenny,
scbedd and
weshaggard
as code owners
October 21, 2019 19:02
Member
|
/azp run python - identity - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chlowell
force-pushed
the
logging-policy
branch
from
October 21, 2019 20:28
4f6bc3a to
314c95f
Compare
lmazuel
approved these changes
Oct 21, 2019
fengzhou-msft
pushed a commit
that referenced
this pull request
Nov 5, 2019
* use HttpLoggingPolicy in azure-identity * use HttpLoggingPolicy in azure-keyvault-* * ... tracing policy takes kwargs now (identity) * ... tracing policy takes kwargs now (keyvault) * allow keyvault header in logging * fix typo * update azure-core dependency * exclude azure.identity from dependency test * remove shared_requirements overrides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
HttpLoggingPolicyto pipelines throughout azure-identity and azure-keyvault-*. I also noticed the tracing policy takes kwargs now, so I pass them now.