[Storage] Bumped version + Pipeline fix

sdk/storage/azure-storage-blob/HISTORY.md

@@ -1,6 +1,6 @@
 # Change Log azure-storage-blob
 
-## Version 12.0.0:
+## Version 12.0.0b5:
 
 **Breaking changes**
 

sdk/storage/azure-storage-blob/azure/storage/blob/_container_client.py

@@ -693,7 +693,7 @@ def upload_blob(
         :param metadata:
             Name-value pairs associated with the blob as metadata.
         :type metadata: dict(str, str)
-        :param str encoding:
+        :keyword str encoding:
             Defaults to UTF-8.
         :keyword bool overwrite: Whether the blob to be uploaded should overwrite the current data.
             If True, upload_blob will silently overwrite the existing data. If set to False, the
@@ -808,10 +808,6 @@ def delete_blob(
         :param blob: The blob with which to interact. If specified, this value will override
          a blob value specified in the blob URL.
         :type blob: str or ~azure.storage.blob.BlobProperties
-        :param str delete_snapshots:
-            Required if the blob has associated snapshots. Values include:
-             - "only": Deletes only the blobs snapshots.
-             - "include": Deletes the blob along with all snapshots.
         :param str delete_snapshots:
             Required if the blob has associated snapshots. Values include:
              - "only": Deletes only the blobs snapshots.

sdk/storage/azure-storage-blob/azure/storage/blob/_shared/base_client.py

@@ -178,6 +178,7 @@ def _create_pipeline(self, credential, **kwargs):
         policies = [
             QueueMessagePolicy(),
             config.headers_policy,
+            config.proxy_policy,
             config.user_agent_policy,
             StorageContentValidation(),
             StorageRequestHook(**kwargs),

sdk/storage/azure-storage-blob/azure/storage/blob/_shared/base_client_async.py

@@ -82,6 +82,7 @@ def _create_pipeline(self, credential, **kwargs):
         policies = [
             QueueMessagePolicy(),
             config.headers_policy,
+            config.proxy_policy,
             config.user_agent_policy,
             StorageContentValidation(),
             StorageRequestHook(**kwargs),

sdk/storage/azure-storage-blob/azure/storage/blob/_version.py

@@ -4,4 +4,4 @@
 # license information.
 # --------------------------------------------------------------------------
 
-VERSION = "12.0.0b4"
+VERSION = "12.0.0b5"

sdk/storage/azure-storage-blob/setup.py

@@ -79,6 +79,7 @@
         'Programming Language :: Python :: 3.5',
         'Programming Language :: Python :: 3.6',
         'Programming Language :: Python :: 3.7',
+        'Programming Language :: Python :: 3.8',
         'License :: OSI Approved :: MIT License',
     ],
     zip_safe=False,

sdk/storage/azure-storage-file/HISTORY.md

@@ -1,6 +1,6 @@
 # Change Log azure-storage-file
 
-## Version 12.0.0:
+## Version 12.0.0b5:
 
 **Breaking changes**
 

sdk/storage/azure-storage-file/azure/storage/file/_shared/base_client.py

@@ -28,7 +28,7 @@
 from azure.core.configuration import Configuration
 from azure.core.exceptions import HttpResponseError
 from azure.core.pipeline import Pipeline
-from azure.core.pipeline.transport import RequestsTransport, HttpTransport  # pylint: disable=unused-import
+from azure.core.pipeline.transport import RequestsTransport, HttpTransport
 from azure.core.pipeline.policies import (
     RedirectPolicy,
     ContentDecodePolicy,
@@ -54,7 +54,7 @@
     ExponentialRetry,
 )
 from .._generated.models import StorageErrorException
-from .response_handlers import process_storage_error
+from .response_handlers import process_storage_error, PartialBatchErrorException
 
 
 _LOGGER = logging.getLogger(__name__)
@@ -178,6 +178,7 @@ def _create_pipeline(self, credential, **kwargs):
         policies = [
             QueueMessagePolicy(),
             config.headers_policy,
+            config.proxy_policy,
             config.user_agent_policy,
             StorageContentValidation(),
             StorageRequestHook(**kwargs),
@@ -199,6 +200,8 @@ def _batch_send(
     ):
         """Given a series of request, do a Storage batch call.
         """
+        # Pop it here, so requests doesn't feel bad about additional kwarg
+        raise_on_any_failure = kwargs.pop("raise_on_any_failure", True)
         request = self._client._client.post(  # pylint: disable=protected-access
             url='https://{}/?comp=batch'.format(self.primary_hostname),
             headers={
@@ -222,7 +225,17 @@ def _batch_send(
         try:
             if response.status_code not in [202]:
                 raise HttpResponseError(response=response)
-            return response.parts()
+            parts = response.parts()
+            if raise_on_any_failure:
+                parts = list(response.parts())
+                if any(p for p in parts if not 200 <= p.status_code < 300):
+                    error = PartialBatchErrorException(
+                        message="There is a partial failure in the batch operation.",
+                        response=response, parts=parts
+                    )
+                    raise error
+                return iter(parts)
+            return parts
         except StorageErrorException as error:
             process_storage_error(error)
 

sdk/storage/azure-storage-file/azure/storage/file/_shared/base_client_async.py

@@ -9,8 +9,8 @@
     TYPE_CHECKING
 )
 import logging
-
 from azure.core.pipeline import AsyncPipeline
+from azure.core.async_paging import AsyncList
 from azure.core.exceptions import HttpResponseError
 from azure.core.pipeline.policies import (
     ContentDecodePolicy,
@@ -34,13 +34,12 @@
 from .policies_async import AsyncStorageResponseHook
 
 from .._generated.models import StorageErrorException
-from .response_handlers import process_storage_error
+from .response_handlers import process_storage_error, PartialBatchErrorException
 
 if TYPE_CHECKING:
     from azure.core.pipeline import Pipeline
     from azure.core.pipeline.transport import HttpRequest
     from azure.core.configuration import Configuration
-
 _LOGGER = logging.getLogger(__name__)
 
 
@@ -83,6 +82,7 @@ def _create_pipeline(self, credential, **kwargs):
         policies = [
             QueueMessagePolicy(),
             config.headers_policy,
+            config.proxy_policy,
             config.user_agent_policy,
             StorageContentValidation(),
             StorageRequestHook(**kwargs),
@@ -104,6 +104,8 @@ async def _batch_send(
     ):
         """Given a series of request, do a Storage batch call.
         """
+        # Pop it here, so requests doesn't feel bad about additional kwarg
+        raise_on_any_failure = kwargs.pop("raise_on_any_failure", True)
         request = self._client._client.post(  # pylint: disable=protected-access
             url='https://{}/?comp=batch'.format(self.primary_hostname),
             headers={
@@ -127,7 +129,19 @@ async def _batch_send(
         try:
             if response.status_code not in [202]:
                 raise HttpResponseError(response=response)
-            return response.parts()  # Return an AsyncIterator
+            parts = response.parts() # Return an AsyncIterator
+            if raise_on_any_failure:
+                parts_list = []
+                async for part in parts:
+                    parts_list.append(part)
+                if any(p for p in parts_list if not 200 <= p.status_code < 300):
+                    error = PartialBatchErrorException(
+                        message="There is a partial failure in the batch operation.",
+                        response=response, parts=parts_list
+                    )
+                    raise error
+                return AsyncList(parts_list)
+            return parts
         except StorageErrorException as error:
             process_storage_error(error)
 

sdk/storage/azure-storage-file/azure/storage/file/_shared/response_handlers.py

@@ -31,6 +31,19 @@
 _LOGGER = logging.getLogger(__name__)
 
 
+class PartialBatchErrorException(HttpResponseError):
+    """There is a partial failure in batch operations.
+
+    :param message: The message of the exception.
+    :param response: Server response to be deserialized.
+    :param parts: A list of the parts in multipart response.
+    """
+
+    def __init__(self, message, response, parts):
+        self.parts = parts
+        super(PartialBatchErrorException, self).__init__(message=message, response=response)
+
+
 def parse_length_from_content_range(content_range):
     '''
     Parses the blob length from the content range header: bytes 1-3/65537

sdk/storage/azure-storage-file/azure/storage/file/_version.py

@@ -4,4 +4,4 @@
 # license information.
 # --------------------------------------------------------------------------
 
-VERSION = '12.0.0b4'
+VERSION = '12.0.0b5'

sdk/storage/azure-storage-file/setup.py

@@ -67,6 +67,7 @@
         'Programming Language :: Python :: 3.5',
         'Programming Language :: Python :: 3.6',
         'Programming Language :: Python :: 3.7',
+        'Programming Language :: Python :: 3.8',
         'License :: OSI Approved :: MIT License',
     ],
     zip_safe=False,

sdk/storage/azure-storage-queue/HISTORY.md

@@ -1,6 +1,6 @@
 # Change Log azure-storage-queue
 
-## Version 12.0.0:
+## Version 12.0.0b5:
 
 **Breaking changes**
 

sdk/storage/azure-storage-queue/azure/storage/queue/_shared/base_client.py

@@ -28,7 +28,7 @@
 from azure.core.configuration import Configuration
 from azure.core.exceptions import HttpResponseError
 from azure.core.pipeline import Pipeline
-from azure.core.pipeline.transport import RequestsTransport, HttpTransport  # pylint: disable=unused-import
+from azure.core.pipeline.transport import RequestsTransport, HttpTransport
 from azure.core.pipeline.policies import (
     RedirectPolicy,
     ContentDecodePolicy,
@@ -54,7 +54,7 @@
     ExponentialRetry,
 )
 from .._generated.models import StorageErrorException
-from .response_handlers import process_storage_error
+from .response_handlers import process_storage_error, PartialBatchErrorException
 
 
 _LOGGER = logging.getLogger(__name__)
@@ -178,6 +178,7 @@ def _create_pipeline(self, credential, **kwargs):
         policies = [
             QueueMessagePolicy(),
             config.headers_policy,
+            config.proxy_policy,
             config.user_agent_policy,
             StorageContentValidation(),
             StorageRequestHook(**kwargs),
@@ -199,6 +200,8 @@ def _batch_send(
     ):
         """Given a series of request, do a Storage batch call.
         """
+        # Pop it here, so requests doesn't feel bad about additional kwarg
+        raise_on_any_failure = kwargs.pop("raise_on_any_failure", True)
         request = self._client._client.post(  # pylint: disable=protected-access
             url='https://{}/?comp=batch'.format(self.primary_hostname),
             headers={
@@ -222,7 +225,17 @@ def _batch_send(
         try:
             if response.status_code not in [202]:
                 raise HttpResponseError(response=response)
-            return response.parts()
+            parts = response.parts()
+            if raise_on_any_failure:
+                parts = list(response.parts())
+                if any(p for p in parts if not 200 <= p.status_code < 300):
+                    error = PartialBatchErrorException(
+                        message="There is a partial failure in the batch operation.",
+                        response=response, parts=parts
+                    )
+                    raise error
+                return iter(parts)
+            return parts
         except StorageErrorException as error:
             process_storage_error(error)
 

sdk/storage/azure-storage-queue/azure/storage/queue/_shared/base_client_async.py

@@ -9,8 +9,8 @@
     TYPE_CHECKING
 )
 import logging
-
 from azure.core.pipeline import AsyncPipeline
+from azure.core.async_paging import AsyncList
 from azure.core.exceptions import HttpResponseError
 from azure.core.pipeline.policies import (
     ContentDecodePolicy,
@@ -34,13 +34,12 @@
 from .policies_async import AsyncStorageResponseHook
 
 from .._generated.models import StorageErrorException
-from .response_handlers import process_storage_error
+from .response_handlers import process_storage_error, PartialBatchErrorException
 
 if TYPE_CHECKING:
     from azure.core.pipeline import Pipeline
     from azure.core.pipeline.transport import HttpRequest
     from azure.core.configuration import Configuration
-
 _LOGGER = logging.getLogger(__name__)
 
 
@@ -83,6 +82,7 @@ def _create_pipeline(self, credential, **kwargs):
         policies = [
             QueueMessagePolicy(),
             config.headers_policy,
+            config.proxy_policy,
             config.user_agent_policy,
             StorageContentValidation(),
             StorageRequestHook(**kwargs),
@@ -104,6 +104,8 @@ async def _batch_send(
     ):
         """Given a series of request, do a Storage batch call.
         """
+        # Pop it here, so requests doesn't feel bad about additional kwarg
+        raise_on_any_failure = kwargs.pop("raise_on_any_failure", True)
         request = self._client._client.post(  # pylint: disable=protected-access
             url='https://{}/?comp=batch'.format(self.primary_hostname),
             headers={
@@ -127,7 +129,19 @@ async def _batch_send(
         try:
             if response.status_code not in [202]:
                 raise HttpResponseError(response=response)
-            return response.parts()  # Return an AsyncIterator
+            parts = response.parts() # Return an AsyncIterator
+            if raise_on_any_failure:
+                parts_list = []
+                async for part in parts:
+                    parts_list.append(part)
+                if any(p for p in parts_list if not 200 <= p.status_code < 300):
+                    error = PartialBatchErrorException(
+                        message="There is a partial failure in the batch operation.",
+                        response=response, parts=parts_list
+                    )
+                    raise error
+                return AsyncList(parts_list)
+            return parts
         except StorageErrorException as error:
             process_storage_error(error)
 

sdk/storage/azure-storage-queue/azure/storage/queue/_shared/response_handlers.py

@@ -31,6 +31,19 @@
 _LOGGER = logging.getLogger(__name__)
 
 
+class PartialBatchErrorException(HttpResponseError):
+    """There is a partial failure in batch operations.
+
+    :param message: The message of the exception.
+    :param response: Server response to be deserialized.
+    :param parts: A list of the parts in multipart response.
+    """
+
+    def __init__(self, message, response, parts):
+        self.parts = parts
+        super(PartialBatchErrorException, self).__init__(message=message, response=response)
+
+
 def parse_length_from_content_range(content_range):
     '''
     Parses the blob length from the content range header: bytes 1-3/65537

sdk/storage/azure-storage-queue/azure/storage/queue/_version.py

@@ -9,4 +9,4 @@
 # regenerated.
 # --------------------------------------------------------------------------
 
-VERSION = "12.0.0b4"
+VERSION = "12.0.0b5"

sdk/storage/azure-storage-queue/setup.py

@@ -67,6 +67,7 @@
         'Programming Language :: Python :: 3.5',
         'Programming Language :: Python :: 3.6',
         'Programming Language :: Python :: 3.7',
+        'Programming Language :: Python :: 3.8',
         'License :: OSI Approved :: MIT License',
     ],
     zip_safe=False,