Skip to content

Fix 8091: expose generated enum to customers#8117

Merged
lmazuel merged 2 commits into
feature/storage-preview5from
fix_8091
Oct 22, 2019
Merged

Fix 8091: expose generated enum to customers#8117
lmazuel merged 2 commits into
feature/storage-preview5from
fix_8091

Conversation

@lmazuel

@lmazuel lmazuel commented Oct 22, 2019

Copy link
Copy Markdown
Member

Fix #8091

@lmazuel lmazuel added Storage Storage Service (Queues, Blobs, Files) Client This issue points to a problem in the data-plane of the library. labels Oct 22, 2019
@AutorestCI

AutorestCI commented Oct 22, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

(message created by the CI based on PR content)

Installation instruction

Package azure-storage-queue

You can install the package azure-storage-queue of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@fix_8091#egg=azure-storage-queue&subdirectory=azure-storage-queue"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@fix_8091#egg=azure-storage-queue&subdirectory=azure-storage-queue"

If you have a local clone of this repository, you can also do:

  • git checkout fix_8091
  • pip install -e ./azure-storage-queue

Or build a wheel file to distribute for testing:

  • git checkout fix_8091
  • pip wheel --no-deps ./azure-storage-queue

Package azure-storage-blob

You can install the package azure-storage-blob of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@fix_8091#egg=azure-storage-blob&subdirectory=azure-storage-blob"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@fix_8091#egg=azure-storage-blob&subdirectory=azure-storage-blob"

If you have a local clone of this repository, you can also do:

  • git checkout fix_8091
  • pip install -e ./azure-storage-blob

Or build a wheel file to distribute for testing:

  • git checkout fix_8091
  • pip wheel --no-deps ./azure-storage-blob

Package azure-storage-file

You can install the package azure-storage-file of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@fix_8091#egg=azure-storage-file&subdirectory=azure-storage-file"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@fix_8091#egg=azure-storage-file&subdirectory=azure-storage-file"

If you have a local clone of this repository, you can also do:

  • git checkout fix_8091
  • pip install -e ./azure-storage-file

Or build a wheel file to distribute for testing:

  • git checkout fix_8091
  • pip wheel --no-deps ./azure-storage-file

Direct download

Your files can be directly downloaded here:

annatisch
annatisch approved these changes Oct 22, 2019
View reviewed changes

@annatisch annatisch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - there are no models in Files and Queues that need this treatment?

xiangyan99
xiangyan99 reviewed Oct 22, 2019
View reviewed changes
Comment thread sdk/storage/azure-storage-blob/tests/test_common_blob_async.py
# Assert
self.assertIsNotNone(copy)
self.assertEqual(copy['copy_status'], 'success')
self.assertFalse(isinstance(copy['copy_status'], Enum))

@xiangyan99 xiangyan99 Oct 22, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to assert it is a string more than just not enum. :)

@lmazuel lmazuel Oct 22, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the first thing I did, but the original is a string AND an enum (multiple inheritance). So both test were True :)
Being that the line before is testing the string, I think we're good :)

@annatisch annatisch Oct 22, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiangyan99 - that's already implied by the assertEqual statement above?

@lmazuel lmazuel added the blocking-release Blocks release label Oct 22, 2019
@lmazuel
lmazuel merged commit 0341e86 into feature/storage-preview5 Oct 22, 2019
@lmazuel
lmazuel deleted the fix_8091 branch October 22, 2019 23:01
rakshith91 pushed a commit that referenced this pull request Oct 23, 2019
@lmazuel Rakshith Bhyravabhotla
Feature/storage preview5 (#8049)
db402b1 
* Fix SubStream to respect IOBase protocol (#7843)

* removes NoRetry policy (#7845)

* [storage] Makes signed_identifiers a required param (#7844)

* makes signed_identifiers a required param

* fix tests and update history

* removes unecessary check

* fix files and queues tests

* [storage] Changes `file_permission_key` param to `permission_key` (#7841)

* changes file_permission_key param to permission_key

* update history

* Change the param directive to keyword in docstrings (#7855)

* Change the directive to keyword in docstrings

* pylint :(

* [storage] Adds from_string to models (#7870)

* adds from_string to models

* fixes to naming and history

* remove _str in docstrings

* pylint

* [storage-file] await async poller (#7872)

* await files async poller

* fix docstrings

* fix type hints

* [File and Queue] Client constructors (#7853)

* from_queue_url

* file client constructors

* update CHANGELOG

* fix test

* lint fix

* some doc changes

* queue docs

* blob docs

* [storage-queue] rename queue messages (#7895)

* rename queue messages

* update history

* [Storage-Queue][Storage-File] Kwargify positional params (#7877)

* Queue kwargification

* kwargify Files

* small fix

* minor fix

* comments + lint

* some changes

* pylint

* [storage-file, queue] moves param protocol to kwargs in gen_shared_access_signature() (#7897)

* moves protocol in gen_sas to kwargs

* delete whitespace

* [storage] Unexposes models from aio (#7881)

* unexposes models from aio

* unexpose all except clients and pylint fixes

* update history

* unexpose sync paged models

* update history phrasing

* [Storage-queue] Allow None message encode policy (#7898)

* Don't expose NoEncode policies

* Support None value for encode/decode policies

* Updated tests

* Updated sync encryption tests

* Updated async encryption tests

* Updated async encoding tests

* Fixed test

* Fix test

* Updated release notes

* Rename enqueue_message to send_messgae (#7928)

* [storage-blob, queue] Renames Logging to <ServiceName>AnalyticsLogging (#7921)

* renames logging to ServiceAnalyticsLogging

* changes param logging to analytics_logging

* fixes tests due to param name change

* [Blob][File][Encryption]Fix Download Encrypted Blob/File Bug (#7965)

#7957

* Consolidate offset - length behavior in files (#7942)

* Initital Commit

* length changes

* some test changes

* some more changes

* history.md

* Update a couple of recrodings

* comments address

* ops

* Stop modifying internal_response body (#7958)

* Stop modifying internal body

* Replicate for queues and files too

* [Storage] Relocated SAS generation (#7955)

* Expose account name on clients

* Updated blob sas gen

* Updated file sas gen

* Update queue sas gen

* Updated docstrings

* Some pylint fixes

* More pylint

* More pylint

* Reverted auth change

* Added release notes

* Fixed kwarg docstring

* [Storage] Updated close handles (#7940)

* Updated close handles

* Pylint fixes

* Fix tests

* Review feedback

* Missing recursive parameter

* Added release notes

* [Storage] Conditional etag parameters (#8047)

* Updated clients

* Process conditional headers

* Updated tests

* Fixed test

* Updated error scenarios

* Updated release notes

* Revert skipped tests

* [Storage] Download stream refactor (#7848)

* Refactored download stream API

* Unskip tests

* Test warnings

* Missing await

* Fixed append tests

* Fixed page tests

* Pylint

* Py2.7 iter support

* Refactor downloaders

* Added missing async module functions

* Updated release notes

* Keyword params

* Documented more keyword options

* Added module functions to exports

* Fixed merge

* Fix for Files download stream

* Pylint fix

* Updated File stream downloads

* Fix tests

* Updated error message

* Added Files release notes

* Pylint fix

* Download stream error handling

* Fixed some tests

* Design Pipeline ownership (#7981)

* Initital Commit

* Pipeline Ownership

* slight modifications

* pipeline ownership for queues and files

* fixes tests, adds docstrings to wrapper classes

* pylint

* Batching APIs Raise on Any Failure (#7963)

* Raise on Single Failure

* some changes

* lint

* some changes

* oops

* comments + lint

* some optimization

* history

* comments

* lint

* recording

* Plug HttpLoggingPolicy to Storage (#8081)

* Plug HttpLoggingPolicy to Storage

* Update dependencies

* Skip depends job for Storage

* Fix shared req

* [storage] make storage files _internal (#7949)

* blobs internal

* files internal

* queues internal

* some fixes to docstrings

* update history.md

* fix async test import

* some file mypy fixes

* some queue mypy fixes

* some blob mypy fixes

* fix mistake in type annot

* history edits

* Merge fix

* Revert "Merge fix"

This reverts commit 748fbd6.

* Better merge fix

* fix some tests (#8100)

* Fix tests (#8103)

* minor fix special char

* fix auth

* comments

* [Storage] Bumped version + Pipeline fix (#8089)

* Bumped version

* Docs tweak

* Re-bumped version

* Added 3.8 classifier

* Added proxy policy to pipeline

* Synced base clients

* Added batch exception

* Comment the echo check to workaround batch headers issue (#8118)

* Fix 8091: expose generated enum to customers (#8117)

* Fix #8091

* Add one in file
fengzhou-msft pushed a commit that referenced this pull request Nov 5, 2019
@lmazuel @fengzhou-msft
Feature/storage preview5 (#8049)
e2faf4b 
* Fix SubStream to respect IOBase protocol (#7843)

* removes NoRetry policy (#7845)

* [storage] Makes signed_identifiers a required param (#7844)

* makes signed_identifiers a required param

* fix tests and update history

* removes unecessary check

* fix files and queues tests

* [storage] Changes `file_permission_key` param to `permission_key` (#7841)

* changes file_permission_key param to permission_key

* update history

* Change the param directive to keyword in docstrings (#7855)

* Change the directive to keyword in docstrings

* pylint :(

* [storage] Adds from_string to models (#7870)

* adds from_string to models

* fixes to naming and history

* remove _str in docstrings

* pylint

* [storage-file] await async poller (#7872)

* await files async poller

* fix docstrings

* fix type hints

* [File and Queue] Client constructors (#7853)

* from_queue_url

* file client constructors

* update CHANGELOG

* fix test

* lint fix

* some doc changes

* queue docs

* blob docs

* [storage-queue] rename queue messages (#7895)

* rename queue messages

* update history

* [Storage-Queue][Storage-File] Kwargify positional params (#7877)

* Queue kwargification

* kwargify Files

* small fix

* minor fix

* comments + lint

* some changes

* pylint

* [storage-file, queue] moves param protocol to kwargs in gen_shared_access_signature() (#7897)

* moves protocol in gen_sas to kwargs

* delete whitespace

* [storage] Unexposes models from aio (#7881)

* unexposes models from aio

* unexpose all except clients and pylint fixes

* update history

* unexpose sync paged models

* update history phrasing

* [Storage-queue] Allow None message encode policy (#7898)

* Don't expose NoEncode policies

* Support None value for encode/decode policies

* Updated tests

* Updated sync encryption tests

* Updated async encryption tests

* Updated async encoding tests

* Fixed test

* Fix test

* Updated release notes

* Rename enqueue_message to send_messgae (#7928)

* [storage-blob, queue] Renames Logging to <ServiceName>AnalyticsLogging (#7921)

* renames logging to ServiceAnalyticsLogging

* changes param logging to analytics_logging

* fixes tests due to param name change

* [Blob][File][Encryption]Fix Download Encrypted Blob/File Bug (#7965)

#7957

* Consolidate offset - length behavior in files (#7942)

* Initital Commit

* length changes

* some test changes

* some more changes

* history.md

* Update a couple of recrodings

* comments address

* ops

* Stop modifying internal_response body (#7958)

* Stop modifying internal body

* Replicate for queues and files too

* [Storage] Relocated SAS generation (#7955)

* Expose account name on clients

* Updated blob sas gen

* Updated file sas gen

* Update queue sas gen

* Updated docstrings

* Some pylint fixes

* More pylint

* More pylint

* Reverted auth change

* Added release notes

* Fixed kwarg docstring

* [Storage] Updated close handles (#7940)

* Updated close handles

* Pylint fixes

* Fix tests

* Review feedback

* Missing recursive parameter

* Added release notes

* [Storage] Conditional etag parameters (#8047)

* Updated clients

* Process conditional headers

* Updated tests

* Fixed test

* Updated error scenarios

* Updated release notes

* Revert skipped tests

* [Storage] Download stream refactor (#7848)

* Refactored download stream API

* Unskip tests

* Test warnings

* Missing await

* Fixed append tests

* Fixed page tests

* Pylint

* Py2.7 iter support

* Refactor downloaders

* Added missing async module functions

* Updated release notes

* Keyword params

* Documented more keyword options

* Added module functions to exports

* Fixed merge

* Fix for Files download stream

* Pylint fix

* Updated File stream downloads

* Fix tests

* Updated error message

* Added Files release notes

* Pylint fix

* Download stream error handling

* Fixed some tests

* Design Pipeline ownership (#7981)

* Initital Commit

* Pipeline Ownership

* slight modifications

* pipeline ownership for queues and files

* fixes tests, adds docstrings to wrapper classes

* pylint

* Batching APIs Raise on Any Failure (#7963)

* Raise on Single Failure

* some changes

* lint

* some changes

* oops

* comments + lint

* some optimization

* history

* comments

* lint

* recording

* Plug HttpLoggingPolicy to Storage (#8081)

* Plug HttpLoggingPolicy to Storage

* Update dependencies

* Skip depends job for Storage

* Fix shared req

* [storage] make storage files _internal (#7949)

* blobs internal

* files internal

* queues internal

* some fixes to docstrings

* update history.md

* fix async test import

* some file mypy fixes

* some queue mypy fixes

* some blob mypy fixes

* fix mistake in type annot

* history edits

* Merge fix

* Revert "Merge fix"

This reverts commit 748fbd6.

* Better merge fix

* fix some tests (#8100)

* Fix tests (#8103)

* minor fix special char

* fix auth

* comments

* [Storage] Bumped version + Pipeline fix (#8089)

* Bumped version

* Docs tweak

* Re-bumped version

* Added 3.8 classifier

* Added proxy policy to pipeline

* Synced base clients

* Added batch exception

* Comment the echo check to workaround batch headers issue (#8118)

* Fix 8091: expose generated enum to customers (#8117)

* Fix #8091

* Add one in file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annatisch annatisch annatisch approved these changes
@xiangyan99 xiangyan99 xiangyan99 approved these changes
@rakshith91 rakshith91 Awaiting requested review from rakshith91
@xiafu-msft xiafu-msft Awaiting requested review from xiafu-msft
@zezha-msft zezha-msft Awaiting requested review from zezha-msft

Assignees

No one assigned

Labels

blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lmazuel @AutorestCI @annatisch @xiangyan99