Skip to content

[storage] fix bug in blob sas logging test #8123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kristapratico wants to merge 1 commit into from
Closed

[storage] fix bug in blob sas logging test #8123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions sdk/storage/azure-storage-blob/tests/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
)

if sys.version_info >= (3,):
from urllib.parse import parse_qs, quote
from urllib.parse import parse_qs, quote, urlparse
else:
from urlparse import parse_qs
from urlparse import parse_qs, urlparse
from urllib2 import quote

_AUTHORIZATION_HEADER_NAME = 'Authorization'
Expand Down Expand Up @@ -131,7 +131,14 @@ def test_copy_source_sas_is_scrubbed_off(self):
dest_blob = self.bsc.get_blob_client(self.container_name, dest_blob_name)

# parse out the signed signature
token_components = parse_qs(self.source_blob_url)
query_parameters = urlparse(self.source_blob_url).query
token_components = parse_qs(query_parameters)
if QueryStringConstants.SIGNED_SIGNATURE not in token_components:
pytest.fail("Blob URL {} doesn't contain {}, parsed query params: {}".format(
self.source_blob_url,
QueryStringConstants.SIGNED_SIGNATURE,
list(token_components.keys())
))
signed_signature = quote(token_components[QueryStringConstants.SIGNED_SIGNATURE][0])

# Act
Expand Down
13 changes: 10 additions & 3 deletions sdk/storage/azure-storage-blob/tests/test_logging_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
)

if sys.version_info >= (3,):
from urllib.parse import parse_qs, quote
from urllib.parse import parse_qs, quote, urlparse
else:
from urlparse import parse_qs
from urlparse import parse_qs, urlparse
from urllib2 import quote

_AUTHORIZATION_HEADER_NAME = 'Authorization'
Expand Down Expand Up @@ -169,7 +169,14 @@ async def _test_copy_source_sas_is_scrubbed_off(self):
dest_blob = self.bsc.get_blob_client(self.container_name, dest_blob_name)

# parse out the signed signature
token_components = parse_qs(self.source_blob_url)
query_parameters = urlparse(self.source_blob_url).query
token_components = parse_qs(query_parameters)
if QueryStringConstants.SIGNED_SIGNATURE not in token_components:
pytest.fail("Blob URL {} doesn't contain {}, parsed query params: {}".format(
self.source_blob_url,
QueryStringConstants.SIGNED_SIGNATURE,
list(token_components.keys())
))
signed_signature = quote(token_components[QueryStringConstants.SIGNED_SIGNATURE][0])

# Act
Expand Down