rewind the body in retry - #8548
Closed
xiangyan99 wants to merge 13 commits into
Closed
Conversation
|
Can one of the admins verify this patch? |
Contributor
|
I think the cosmos emulator / prod test differences have been address, maybe a rebase would fix things. Otherwise, my only comment is that a test would be advised to make sure this behavior is preserved. |
* move remaining smoketest files out of samples folder (this branch was open a long time ago and the new files were missed in a rebase) add remaining KV smoke tests back in add to requirements allow for other versions of python 3.7 update to use older interfaces fix up smoke tests for september 2019 preview name the matrix entry properly do not wait for cert creation in b3 * [AutoPR] azure-kusto/resource-manager (#7300) * Generated from 8264dcc49e0bc239013cd76ce9664f83f1041967 (#7036) Update Kusto.json with TSVE data format * Generated from 1998560b95ad1853979c663b19710407a2266926 (#7299) Updated readme files * Generated from 63d0bd0751dd12efb7a19fd63807a26919c02b11 (#7424) Add support for attached databases * regenerated kusto * changelist and version * removed files that were generated by mistake * Restapi auto eventgrid/resource manager (#8570) * regenerated eventgrid * history and version * changed version to rc2 * Update root readme with November releases (#8462) * Update root readme with Novemeber releases * Update README.md * Update README.md * Make preparer force https for storage account (#8563) * Update storage_testcase.py * small fix * Get Package namespace by parsing setup.py (#8461)
xiangyan99
requested review from
danieljurek,
mitchdenny,
scbedd,
weshaggard and
zikalino
as code owners
November 12, 2019 00:39
lmazuel
requested changes
Nov 13, 2019
lmazuel
left a comment
lmazuel
left a comment
Member
There was a problem hiding this comment.
I think "body" is not the type you expect, or if you actually saw that, there is a bigger conversation to have.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #8307