Skip to content

Nightly build is failing due version conflict between storage datalak… #8635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praveenkuttappan merged 3 commits into from
Nov 14, 2019
Merged

Nightly build is failing due version conflict between storage datalak… #8635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec9d513
Nightly build is failing due version conflict between storage datalak…
praveenkuttappan Nov 14, 2019
efa6b59
review changes
praveenkuttappan Nov 14, 2019
03fdad9
Version dependency with azure-storage-blob to 12.0
praveenkuttappan Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-file-datalake/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
install_requires=[
"azure-core<2.0.0,>=1.0.0",
"msrest>=0.6.10",
"azure-storage-blob~=12.0.0"
Comment thread
scbedd marked this conversation as resolved.
"azure-storage-blob~=12.0"
],
extras_require={
":python_version<'3.0'": ['futures', 'azure-storage-nspkg<4.0.0,>=3.0.0'],
Expand Down
2 changes: 1 addition & 1 deletion shared_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ six>=1.6
#override azure-storage-queue msrest>=0.6.10
#override azure-storage-file-share msrest>=0.6.10
#override azure-storage-file-datalake msrest>=0.6.10
#override azure-storage-file-datalake azure-storage-blob~=12.0.0
#override azure-storage-file-datalake azure-storage-blob~=12.0

@xiafu-msft xiafu-msft Nov 14, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it necessary to touch the version here?
Could we upgrade the version of nightly build to 12.0.0 instead of using the preview version?

opencensus>=0.6.0
opencensus-ext-threading
opencensus-ext-azure>=0.3.1
Expand Down