trigger CI for track2 when tools is changed - #9699
Merged
Praveen Kuttappan (praveenkuttappan) merged 2 commits intoFeb 3, 2020
Merged
Conversation
Praveen Kuttappan (praveenkuttappan)
requested a review
from Mitch Denny (mitchdenny)
as a code owner
February 3, 2020 22:41
Praveen Kuttappan (praveenkuttappan)
requested a review
from Scott Beddall (scbedd)
February 3, 2020 22:41
Laurent Mazuel (lmazuel)
previously approved these changes
Feb 3, 2020
Scott Beddall (scbedd)
previously approved these changes
Feb 3, 2020
Praveen Kuttappan (praveenkuttappan)
dismissed stale reviews from Scott Beddall (scbedd) and Laurent Mazuel (lmazuel)
via
February 3, 2020 23:08
15d8869
Laurent Mazuel (lmazuel)
approved these changes
Feb 3, 2020
Member
|
Praveen Kuttappan (@praveenkuttappan) Scott Beddall (@scbedd) is there a reason we want to trigger ci for all these pipelines if anything under eng changes? We generally use one pipeline like core as a proxy for those changes to prevent all pipelines from triggering. I noticed while merging #10761 that we ran a lot more ci pipelines then I expected to see which is what triggered me to find this PR. |
Member
Author
|
I believe it as per the discussion with Laurent we made change to trigger all track2 pipelines when anything inside eng is changed. I am trying to find that discussion thread. But we should probably add more granular control so it wont trigger all when anything in eng is changed. for e.g. eng/common. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trigger CI for core and track2 packages when tools is changed.