This repository was archived by the owner on Jun 5, 2026. It is now read-only.
[pyproto] async perf improvement - #311
Merged
yunhaoling merged 3 commits intoMar 4, 2022
Merged
Conversation
annatisch
reviewed
Mar 3, 2022
annatisch
reviewed
Mar 4, 2022
| for task in tasks: | ||
| task.cancel() | ||
| for _ in range(batch): | ||
| if await asyncio.ensure_future(self._listen_one_frame(**kwargs)): |
Member
There was a problem hiding this comment.
What's the benefit in using ensure_future if we're going to directly await the coroutine?
Contributor
Author
There was a problem hiding this comment.
in my experiment, ensure_future actually gives better performance than await..
let me add a todo to further test the diff here.
annatisch
approved these changes
Mar 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addressing issue: Azure/azure-sdk-for-python#21142