Skip to content

Fixes url cred leaks caused by surrounding url in quotes #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscalev merged 2 commits into from
Dec 1, 2025
Merged

Fixes url cred leaks caused by surrounding url in quotes #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e27ba70
Fixes cred leak when leading and trailing quotes appear
jscalev Nov 21, 2025
40b2aba
Fixes test name
jscalev Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/urlutil/urlerrorhelper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ func RemoveUrlFromErr(err error) error {
}

func IsValidUrl(urlstring string) bool {
u, parseError := url.Parse(urlstring)
// Remove leading and trailing quotes
noQuotes := strings.Trim(urlstring, `"'`)
u, parseError := url.Parse(noQuotes)
if parseError == nil && u.Scheme != "" && u.Host != "" {
return true
}
Expand Down
9 changes: 9 additions & 0 deletions pkg/urlutil/urlerrorhelper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import (
"fmt"
"strings"
"testing"

"github.com/stretchr/testify/require"
)

func Test_expectedErrorString(t *testing.T) {
Expand All @@ -19,6 +21,13 @@ func Test_expectedErrorString(t *testing.T) {
}
}

func Test_TrailingLeadingQuotes(t *testing.T) {
errorString := "Get \"https://rm-agent.prod.manageddevops.microsoft.com/1223456/AngryChipmunk-x64.tar.gz?expires=12345&keyId=mykey&signature=notasignature\": EOF' :"
inputErr := fmt.Errorf("%s", errorString)
outputErr := RemoveUrlFromErr(inputErr)
require.Equal(t, "Get [REDACTED] EOF' :", outputErr.Error())
}

func Test_nonHttpsSchema(t *testing.T) {
errorString := `Gethttps://aaaaaaaa.blob.core.windows.net/nodeagentpackage-version9-0-0-381/Ubuntu-16.04/batch_config-ubuntu-16.04-1.5.9.tar.gz?sv=2018-03-28&sr=b&sig=a%secret%2Bsecret&st=2019-05-17T01%3A25%3A42Z&se=2021-05-24T01%3A25%3A42Z&sp=r: dial tcp 13.68.165.64:443: i/o timeout`
inputErr := fmt.Errorf("%s", errorString)
Expand Down
Loading