Missing/Invalid Default Value (Group 4)#3454
Merged
Merged
Conversation
souvikghosh04
requested review from
Alekhya-Polavarapu,
Aniruddh25,
JerryNixon,
RubenCerna2079,
aaronburtle,
anushakolan,
rusamant,
sourabh1007,
stuartpa and
vadeveka
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the DAB JSON schema to explicitly document the runtime defaults for enabling REST and GraphQL endpoints, aligning schema annotations with the existing runtime behavior implemented in the C# options records.
Changes:
- Add
"default": trueforruntime.rest.enabledindab.draft.schema.json. - Add
"default": trueforruntime.graphql.enabledindab.draft.schema.json.
Aniruddh25
approved these changes
Apr 24, 2026
anushakolan
approved these changes
Apr 24, 2026
github-project-automation
Bot
moved this from Review In Progress
to Done
in Data API builder
RubenCerna2079
added a commit
that referenced
this pull request
May 7, 2026
…3417, #3444, #3454, #3471) (#3505) Cherry-picks CLI HelpText and schema description improvements from main to release/2.0: - 45f18e2 lowercase CLI enum values in HelpText and error messages (Group 3) (#3444) - d8e0aa4 fix: align CLI HelpText defaults and descriptions with JSON schema (Group 2) (#3417) - 93edc20 Missing/Invalid Default Value (Group 4) (#3454) - acd6bf7 fix: improve schema descriptions (Group 5) (#3471) **Note:** This PR should be merged after #3504 (CLI structure fixes) as it depends on the new options introduced there. --------- Co-authored-by: Aniruddh Munde <anmunde@microsoft.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: RubenCerna2079 <32799214+RubenCerna2079@users.noreply.github.com> Co-authored-by: Ruben Cerna <rcernaserna@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
Parent issue #3466
Closes #3366 —
runtime.rest.enabledhas nodefaultin the JSON schemaCloses #3367 —
runtime.graphql.enabledhas nodefaultin the JSON schemaThese schema properties were missing an explicit
defaultvalue.5 of 7 Group 4 issues (#3378–#3382) were already fixed in PR #3417 as Group 2 overlaps.
What is this change?
Adds
"default": trueto theenabledproperty under bothruntime.restandruntime.graphqlinschemas/dab.draft.schema.json. This matches the C# runtime behavior where both REST and GraphQL are enabled by default.How was this tested?
Schema-only metadata change — no runtime behavior affected. Validated that the schema still passes JSON Schema draft-07 validation.
Sample Request(s)
NA