Skip to content

feat: Add kubernetes.azure.com/scalesetpriority to WellKnownLabels#1284

Merged
matthchr merged 2 commits intomainfrom
matthchr/label-scalesetpriority
Jan 8, 2026
Merged

feat: Add kubernetes.azure.com/scalesetpriority to WellKnownLabels#1284
matthchr merged 2 commits intomainfrom
matthchr/label-scalesetpriority

Conversation

@matthchr
Copy link
Member

@matthchr matthchr commented Dec 3, 2025

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

Add scheduling support for the kubernetes.azure.com/scalesetpriority label.

tallaxes
tallaxes previously approved these changes Dec 4, 2025
tallaxes
tallaxes previously approved these changes Jan 7, 2026
Copy link
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rerun E2E?

@matthchr
Copy link
Member Author

matthchr commented Jan 7, 2026

kicked off E2E, will wait til it passes.

@matthchr
Copy link
Member Author

matthchr commented Jan 8, 2026

Ok so E2E passed, except...
Initial run had:
suite-Drift

should respect budgets for non-empty replace drift

Failed, due to:

  STEP: checking the final count of nodes and nodeclaims - /home/runner/work/karpenter-provider-azure/karpenter-provider-azure/test/suites/drift/suite_test.go:296 @ 01/07/26 19:24:29.587
  [FAILED] Expected
      <int>: 6
  to be ==
      <int>: 5
  In [It] at: /home/runner/work/karpenter-provider-azure/karpenter-provider-azure/test/suites/drift/suite_test.go:297 @ 01/07/26 19:24:29.587

Which I think is a flake, as well as consolidation test suite interrupted and suite-scheduling

[FAIL] Scheduling Provisioning [It] should provision a node for naked pods

This one looked like a pod failed when it was scheduled to the node:

[CREATED/UPDATED 2026-01-07T19:34:19Z] POD default/trackberry-51-v5kkaxatsr provisionable=false phase=Failed nodename=aks-racersheer-49-d7fykcz147-xsc2s owner=[]v1.OwnerReference(nil) [bardwalnut-52-dxqknnz1tw restarts=0]

but it passed on retry so I am wondering if it was something like container pull throttling... not an issue with this change.

@matthchr
Copy link
Member Author

matthchr commented Jan 8, 2026

Overall I think this LGTM for E2E pass now (see the link). Only failing suite is consolidation which we know has some flakes atm.

@matthchr matthchr merged commit cff8ea1 into main Jan 8, 2026
18 checks passed
@matthchr matthchr deleted the matthchr/label-scalesetpriority branch January 8, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants