Add nil checks for vm.Properties.TimeCreated with fallback to preserve GC grace period

[Copilot]

• Understand the issue: Add nil checks for vm.Properties and vm.Properties.TimeCreated before accessing on line 535
• Review existing code patterns for nil checks (line 541 shows the pattern)
• Add nil check for vm.Properties and vm.Properties.TimeCreated on line 535
• Add tests to validate the nil check behavior
• Run tests to verify the changes work correctly
• Run linter to ensure code quality (go vet passed, code formatted with gofmt)
• Address feedback: Add fallback to time.Now() to preserve 5-minute garbage collection grace period
• Add TODO and comment about risk if TimeCreated is never populated
• Final code review

Summary: Added nil checks for vm.Properties.TimeCreated with a fallback to time.Now() to prevent nil pointer dereference while ensuring the garbage collection 5-minute grace period is always enforced.

TODO Added: Documented the potential risk that if vm.Properties.TimeCreated is NEVER populated, the VM might never be garbage collected since we call this helper every time we create an in-memory NodeClaim. The code assumes VMs that fail to come up should eventually stop appearing in Azure API responses.

Original prompt

On cloudprovider.go:499-499, Can you create a PR to check if vm.Properties or vm.Properties.TimeCreated are nil before setting this creationtimestamp? Create a PR based off of the main branch please.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[matthchr]

I think I am fine with this as-is for now but based on investigation on what caused this panic i nthe first place we may need some additional logic here.

[rakechill]

will approve once the requested TODO comment is added

[Copilot]

will approve once the requested TODO comment is added

The TODO comment has been added in commit 7e8e1be. It documents the risk if vm.Properties.TimeCreated is never populated and suggests investigating a more fail-safe approach.