Skip to content

feat: Enable LocalDNS Preferred mode for K8s 1.35+#1401

Merged
matthchr merged 6 commits intomainfrom
sakwa/localdns_135
Feb 5, 2026
Merged

feat: Enable LocalDNS Preferred mode for K8s 1.35+#1401
matthchr merged 6 commits intomainfrom
sakwa/localdns_135

Conversation

@saewoni
Copy link
Contributor

@saewoni saewoni commented Feb 4, 2026

Fixes #

Description
Lower enabling LocalDNS Preferred mode for k8s version 1.35+, lowered from 1.36+.
How was this change tested?

  • Unit Tests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


yewmsft
yewmsft previously approved these changes Feb 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR lowers the minimum Kubernetes version requirement for enabling LocalDNS in Preferred mode from 1.36+ to 1.35+. This change affects the IsLocalDNSEnabled() method implementation and adds comprehensive test coverage for both API versions.

Changes:

  • Updated IsLocalDNSEnabled() method to enable LocalDNS Preferred mode for Kubernetes 1.35+ (down from 1.36+)
  • Added comprehensive unit tests for LocalDNS enablement logic in both v1beta1 and v1alpha2 API versions
  • Updated function documentation and inline comments to reflect the new version requirement

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
pkg/apis/v1beta1/aksnodeclass.go Updated IsLocalDNSEnabled() to check for K8s >= 1.35 instead of >= 1.36
pkg/apis/v1alpha2/aksnodeclass.go Updated IsLocalDNSEnabled() to check for K8s >= 1.35 instead of >= 1.36
pkg/apis/v1beta1/aksnodeclass_localdns_test.go Added comprehensive unit tests for LocalDNS enablement logic covering all modes and version edge cases
pkg/apis/v1alpha2/aksnodeclass_localdns_test.go Added comprehensive unit tests for LocalDNS enablement logic covering all modes and version edge cases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saewoni, need to update some of the tests to reflect the change (see CI). You can run them locally with make presubmit

(We should also remember to run Integration E2E tests on 1.35 - when it is available to test)

@matthchr matthchr merged commit b00e7e1 into main Feb 5, 2026
14 checks passed
@matthchr matthchr deleted the sakwa/localdns_135 branch February 5, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants