refactor: extract vminstancenic.go (PR 2/3)#1485
Open
comtalyst wants to merge 1 commit intocomtalyst/vm-path-refactor-1-utilsfrom
Open
refactor: extract vminstancenic.go (PR 2/3)#1485comtalyst wants to merge 1 commit intocomtalyst/vm-path-refactor-1-utilsfrom
comtalyst wants to merge 1 commit intocomtalyst/vm-path-refactor-1-utilsfrom
Conversation
comtalyst
force-pushed
the
comtalyst/vm-path-refactor-1-utils
branch
from
678a458 to
873f8d0
Compare
comtalyst
force-pushed
the
comtalyst/vm-path-refactor-2-nic
branch
from
92508b9 to
9e72b5e
Compare
comtalyst
force-pushed
the
comtalyst/vm-path-refactor-1-utils
branch
from
873f8d0 to
5e7f32c
Compare
comtalyst
force-pushed
the
comtalyst/vm-path-refactor-2-nic
branch
from
9e72b5e to
94d8d93
Compare
comtalyst
force-pushed
the
comtalyst/vm-path-refactor-1-utils
branch
from
5e7f32c to
4e37401
Compare
comtalyst
force-pushed
the
comtalyst/vm-path-refactor-2-nic
branch
from
94d8d93 to
d152b26
Compare
comtalyst
force-pushed
the
comtalyst/vm-path-refactor-1-utils
branch
from
4e37401 to
8841fb2
Compare
comtalyst
force-pushed
the
comtalyst/vm-path-refactor-2-nic
branch
from
d152b26 to
38fd0d0
Compare
comtalyst
force-pushed
the
comtalyst/vm-path-refactor-1-utils
branch
from
8841fb2 to
7d04147
Compare
comtalyst
force-pushed
the
comtalyst/vm-path-refactor-2-nic
branch
from
38fd0d0 to
e6df9d4
Compare
comtalyst
force-pushed
the
comtalyst/vm-path-refactor-1-utils
branch
from
7d04147 to
937d6d9
Compare
comtalyst
force-pushed
the
comtalyst/vm-path-refactor-2-nic
branch
from
e6df9d4 to
8b6d4de
Compare
comtalyst
force-pushed
the
comtalyst/vm-path-refactor-1-utils
branch
from
937d6d9 to
f7ed3ee
Compare
Move NIC construction functions from vminstance.go to vminstancenic.go: - createNICOptions struct - newNetworkInterfaceForVM - applyTemplateToNic - createNetworkInterface Add buildAndCreateNIC orchestrator that consolidates the NIC creation logic (backend pools, NSG resolution, NIC construction) previously scattered inline in beginLaunchInstance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
comtalyst
force-pushed
the
comtalyst/vm-path-refactor-2-nic
branch
from
8b6d4de to
674a3dd
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Extract NIC construction functions from
vminstance.gointovminstancenic.go:createNICOptions,newNetworkInterfaceForVM,applyTemplateToNic,createNetworkInterface.Add
buildAndCreateNICorchestrator that consolidates backend pool fetching, NSG resolution, and NIC creation (previously scattered inline inbeginLaunchInstance). SimplifybeginLaunchInstanceby replacing inline NIC logic with singlebuildAndCreateNICcall.Part 2 of 3 in the VM path refactoring series. Stacked on PR 1 (#1484).
How was this change tested?
go build ./...passesgo test ./pkg/providers/instance/...passesgo test ./pkg/cloudprovider/...passesDoes this change impact docs?
Release Note