refactor: convert pure unit tests from Ginkgo to table-driven#1499
Open
comtalyst wants to merge 2 commits intocomtalyst/test-reunificationfrom
Open
refactor: convert pure unit tests from Ginkgo to table-driven#1499comtalyst wants to merge 2 commits intocomtalyst/test-reunificationfrom
comtalyst wants to merge 2 commits intocomtalyst/test-reunificationfrom
Conversation
comtalyst
force-pushed
the
refactor/ginkgo-to-table-driven
branch
2 times, most recently
from
35517ad to
3046b8e
Compare
comtalyst
force-pushed
the
comtalyst/test-reunification
branch
from
8b2b5bf to
3c495a6
Compare
comtalyst
force-pushed
the
refactor/ginkgo-to-table-driven
branch
from
3046b8e to
3537d4c
Compare
comtalyst
force-pushed
the
comtalyst/test-reunification
branch
from
3c495a6 to
f26017e
Compare
comtalyst
force-pushed
the
refactor/ginkgo-to-table-driven
branch
from
3537d4c to
fc50bf7
Compare
…codebase Converts pure unit tests (no external dependencies, no provisioning, no env.Client) from Ginkgo BDD-style to standard Go table-driven tests for improved developer experience and faster execution. Files converted: - pkg/apis/v1beta1: hash, localdns, status tests - pkg/apis/v1alpha2: hash, localdns, status tests - pkg/utils: subnet parser tests - pkg/providers/instance: helpers and utils tests - pkg/providers/instancetype: ephemeral disk and kube reserved (extracted) - pkg/metrics: image selection error count - pkg/operator/options: validation, env var fallback, all option tests E2E tests using ExpectProvisionedAndWaitForPromises remain in Ginkgo. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
comtalyst
force-pushed
the
refactor/ginkgo-to-table-driven
branch
from
fc50bf7 to
9288de1
Compare
comtalyst
commented
Mar 8, 2026
The file no longer uses Ginkgo and has been fully converted to standard Go table-driven tests, so the Ginkgo-convention "suite_test.go" name is misleading. Rename to "options_test.go" per standard Go conventions. Addresses review comment on PR #1499. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Converts pure unit tests (no external dependencies, no provisioning, no env.Client) from Ginkgo BDD-style to standard Go table-driven tests for improved developer experience and faster execution.
Files converted:
pkg/apis/v1beta1: hash, localdns, status testspkg/apis/v1alpha2: hash, localdns, status testspkg/utils: subnet parser testspkg/providers/instance: helpers and utils testspkg/providers/instancetype: ephemeral disk and kube reserved (extracted to separate files)pkg/metrics: image selection error countpkg/operator/options: validation, env var fallback, all option testsE2E tests using
ExpectProvisionedAndWaitForPromisesorenv.Clientremain in Ginkgo.How was this change tested?
go test -v -run TestXxx ./pkg/...go build ./...golangci-lint-custom runpasses with 0 issues on all modified packagesDoes this change impact docs?
Release Note