Skip to content

Fix Azure Login in pr-check #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zijchen merged 3 commits into from
Mar 10, 2023
+6 −1
Merged

Fix Azure Login in pr-check #171

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8e6115
Don't use AZURE_CREDENTIALS
zijchen Mar 10, 2023
c8886c4
Add workflow permissions
zijchen Mar 10, 2023
ad4d65b
Fix secrets names
zijchen Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/pr-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
paths:
- '.github/workflows/pr-check.yml'

permissions:
id-token: write # This is needed for Azure login with OIDC

jobs:
deploy:
environment: Automation test # this environment requires approval before running the action
Expand Down Expand Up @@ -45,7 +48,9 @@ jobs:
- name: Azure Login
uses: azure/login@v1
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}

# Deploy a DACPAC with only a table to server
- name: Test DACPAC Action
Expand Down