This repository was archived by the owner on Sep 29, 2023. It is now read-only.
Fix an incorrect variable name - #174
Merged
Merged
Conversation
It was a missing piece of a previous change. We will discuss more in PR.
abhidnya13
self-requested a review
October 16, 2018 18:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was the missing piece from another change happened 3 years ago.
The interesting thing is, this incorrect variable name exists for 3 years and it does NOT affect the actual functionality. This is because that part of variable and its information are not used in current business logic at all. Such a fact is a strong sign that the current code structure has room for improvement. We are rewriting the entire mex.py in a new project.
Since we spot this issue here, we still send out this patch for this code base.