Skip to content

Switch to MSAL 1.29+'s TokenCache.search() - #131

Closed
Ray Luo (rayluo) wants to merge 1 commit into
devfrom
search
Closed

Switch to MSAL 1.29+'s TokenCache.search()#131
Ray Luo (rayluo) wants to merge 1 commit into
devfrom
search

Conversation

@rayluo

Copy link
Copy Markdown
Contributor

This PR will only work when this MSAL PR is merged and shipped (possibly in version 1.29).

CC Jiashuo Li (@jiasli)

@musicinmybrain

Copy link
Copy Markdown
Contributor

MSAL 1.29 has shipped, with the necessary PR.

@musicinmybrain

Copy link
Copy Markdown
Contributor

Note that the release notes say that TokenCache.search() returns a generator, while a compatibility TokenCache.find() (not TokenCache._find()!) returns a list and produces a DeprecationWarning.

@rayluo
Ray Luo (rayluo) deleted the search branch June 23, 2024 01:36
@rayluo
Ray Luo (rayluo) restored the search branch June 23, 2024 01:38
@rayluo

Ray Luo (rayluo) commented Jun 23, 2024

Copy link
Copy Markdown
Contributor Author

Ben Beasley (@musicinmybrain) , you have sharp eyes to notice that MSAL 1.29 was released just hours ago!

Don't worry. We are also shipping the MSAL Extensions 1.2.0 soon. UPDATE: Shipped!

@jiasli

Copy link
Copy Markdown
Contributor

I saw this PR got superseded by 6fd4920.

Just a kind reminder that it is better to make the _find -> search change and version bump in separate PRs. Consider you need to revert this _find -> search change but not the version bump. Separate PRs can be handy in such situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants