Restore compatibility with portalocker < 1.4.0 - #50
Merged
Conversation
Contributor
Author
|
Do you intend to keep support for Python 2 even though it's EOL? If so let me know and I'll rework this |
Ray Luo (rayluo)
suggested changes
Apr 23, 2020
Contributor
|
Luca Boccassi (@bluca) If at all possible, please prioritize this fix. We found and fixed a separated bug in 0.2.0+ series, and we would like to have a new bugfix release 0.2.2 first thing next week. Ideally your improvement here can also go in in that release. |
Support for passing parameters through to the open syscall was added in version 1.4.0. Check before using this feature to keep backward compatibility. wolph/portalocker@721b3309c2
Luca Boccassi (bluca)
force-pushed
the
portalocker_1.4.0
branch
from
April 25, 2020 09:33
6219451 to
47ce9a7
Compare
Ray Luo (rayluo)
approved these changes
Apr 25, 2020
Ray Luo (rayluo)
left a comment
Ray Luo (rayluo)
left a comment
Contributor
There was a problem hiding this comment.
Thanks Luca! We will cut a new release soon!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for passing parameters through to the open syscall was added in
version 1.4.0. Check before using this feature to keep backward compatibility.
wolph/portalocker@721b3309c2
The dependency would cut off the current Debian Stable and Ubuntu before 19.10