Deprecate ResponseMode.QUERY in system browser auth flow, automatically override to FORM_POST with warning #1004
+31
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly override to FORM_POST with warning
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request deprecates the ResponseMode.QUERY option in the system browser authentication flow due to lack of support. When developers pass ResponseMode.QUERY, it is now automatically overridden to ResponseMode.FORM_POST with a warning log message, ensuring backward compatibility.
Changes:
- Added deprecation annotation to
ResponseMode.QUERYenum value with documentation explaining the override behavior - Implemented automatic override logic in
AuthorizationRequestUrlParametersto convert QUERY to FORM_POST with a warning log - Replaced comprehensive optional parameters test with a focused test for QUERY override behavior
- Added build artifact (log4j.properties) to version control
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ResponseMode.java | Added deprecation annotation and documentation to QUERY enum value |
| msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthorizationRequestUrlParameters.java | Implemented override logic to convert QUERY to FORM_POST with warning, added deprecation to responseMode() method |
| msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/AuthorizationRequestUrlParametersTest.java | Replaced comprehensive optional parameters test with focused QUERY override validation test |
| msal4j-persistence-extension/target/test-classes/log4j.properties | Added log4j configuration file in build output directory |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
msal4j-persistence-extension/target/test-classes/log4j.properties
Outdated
Show resolved
Hide resolved
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthorizationRequestUrlParameters.java
Outdated
Show resolved
Hide resolved
Avery-Dunn
reviewed
Jan 12, 2026
msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/AuthorizationRequestUrlParametersTest.java
Show resolved
Hide resolved
Avery-Dunn
reviewed
Jan 12, 2026
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthorizationRequestUrlParameters.java
Outdated
Show resolved
Hide resolved
Avery-Dunn
requested changes
Jan 13, 2026
Contributor
Avery-Dunn
left a comment
Avery-Dunn
left a comment
There was a problem hiding this comment.
See above comments: looks like there are some unnecessary additions and changes to the tests.
…nRequestUrlParameters.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Avery-Dunn
reviewed
Jan 16, 2026
msal4j-persistence-extension/target/test-classes/log4j.properties
Outdated
Show resolved
Hide resolved
Avery-Dunn
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system browser authentication flow no longer supports query response mode. This change deprecates ResponseMode.QUERY . When developers pass ResponseMode.QUERY, it will be automatically overridden to FORM_POST with a warning log, ensuring backward compatibility while guiding users to the supported mode.