Supporting https://contoso.ciamlogin.com as authority - #543
Merged
Conversation
Ray Luo (rayluo)
force-pushed
the
tenant.ciamlogin.com
branch
from
March 31, 2023 23:32
35326b5 to
9b1f887
Compare
Ray Luo (rayluo)
changed the base branch from
login.ciamlogin.com/tenant.onmicrosoft.com
to
ciam
March 31, 2023 23:38
Ray Luo (rayluo)
changed the title
Ray Luo (rayluo)
marked this pull request as ready for review
April 1, 2023 00:29
Ray Luo (rayluo)
force-pushed
the
tenant.ciamlogin.com
branch
from
April 1, 2023 01:39
9b1f887 to
4937978
Compare
Ray Luo (rayluo)
commented
Apr 1, 2023
Ray Luo (rayluo)
commented
Apr 1, 2023
jennyf19
approved these changes
Apr 1, 2023
Ray Luo (rayluo)
force-pushed
the
tenant.ciamlogin.com
branch
from
April 3, 2023 18:09
4937978 to
b33f765
Compare
Ray Luo (rayluo)
force-pushed
the
tenant.ciamlogin.com
branch
3 times, most recently
from
April 6, 2023 07:55
13d652c to
6a5317e
Compare
Jean-Marc Prieur (jmprieur)
approved these changes
Apr 12, 2023
Jean-Marc Prieur (jmprieur)
left a comment
Jean-Marc Prieur (jmprieur)
left a comment
There was a problem hiding this comment.
LGTM
Thanks Ray Luo (@rayluo)
Ray Luo (rayluo)
force-pushed
the
tenant.ciamlogin.com
branch
from
April 12, 2023 18:23
6a5317e to
c0fd20e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The automation tests
currently fail becausepasses:the new domain name is unavailablethe OIDC discovery endpoint is not available. When it is available, it is expected to also be in the ".../v2.0/..." endpoint.we will continue the prototyping after the above two become availableWaiting on new lab apiNew lab api has been updated to return a new authorityUPDATE: The lab API has been changed again in Adjustment for new CIAM partition #564.Testers shall take a look into logs to double check your auth/token requests were sent out to
https://msidlabciam1.ciamlogin.com/d57fb3d4-4b5a-4144-9328-9c1f7d58179d/oauth2/v2.0/token?dc=ESTS-PUB-EUS-AZ1-FD000-TEST1which was discovered from OIDC discovery. If an MSAL you are working on does not obtain those endpoints from OIDC discovery, you could probably usehttps://msidlabciam1.ciamlogin.com/TENANT.ONMICROSOFT.COM/oauth2/v2.0/token?dc=ESTS-PUB-EUS-AZ1-FD000-TEST1instead.