Skip to content

Add enable_pii_log and wire it up with MsalRuntime - #590

Merged
Ray Luo (rayluo) merged 1 commit into
devfrom
enable-pii
Aug 23, 2023
Merged

Add enable_pii_log and wire it up with MsalRuntime#590
Ray Luo (rayluo) merged 1 commit into
devfrom
enable-pii

Conversation

@rayluo

@rayluo Ray Luo (rayluo) commented Aug 18, 2023

Copy link
Copy Markdown
Contributor

A new enable_pii_log parameter will be added into API surface. To use this new behavior, an app would need to declare dependency of msal>=1.24,<2.

This will resolve #568

@rayluo Ray Luo (rayluo) changed the title Add enable_pii and wire it up with MsalRuntime Add enable_pii_log and wire it up with MsalRuntime Aug 18, 2023
@rayluo
Ray Luo (rayluo) merged commit bba6b14 into dev Aug 23, 2023
@rayluo
Ray Luo (rayluo) deleted the enable-pii branch August 23, 2023 08:10
@jiasli

Copy link
Copy Markdown
Contributor

Can we make sure msal_telemetry contains no PII when enable_pii_log is set to True? In my opinion, msal_telemetry should not contain PII under any circumstances.

@rayluo

Copy link
Copy Markdown
Contributor Author

Can we make sure msal_telemetry contains no PII when enable_pii_log is set to True? In my opinion, msal_telemetry should not contain PII under any circumstances.

If I remember correctly, that was indeed the design. enable_pii_log only affects logs. I'm also CCing MSamWils , Ashok Kumar Ramakrishnan (@ashok672) , fengga to keep me honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSAL logging discrepancy

2 participants