Deprecate allow_broker, use enable_broker_on_windows - #613
Merged
Conversation
Bogdan Gavril (bgavrilMS)
approved these changes
Oct 30, 2023
This was referenced Oct 31, 2023
Jiashuo Li (jiasli)
approved these changes
Nov 2, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates the old
ClientApplication.__init__(..., allow_broker=True). Please usePublicClientApplication.__init__(..., enable_broker_on_windows=True)instead.This change is the first step for us to moving to per-platform opt-in flag.
This PR will also close #510 , because we no longer go with that direction.
Jiashuo Li (@jiasli) , Xiang Yan (@xiangyan99),