Attempts account removal from broker first

[Ray Luo (rayluo)]

This change is inspired by this conversation.

CC: Jiashuo Li (@jiasli)

[Ashok Kumar Ramakrishnan (ashok672)]

what if broker sign out also throws an unexpected exception? Is this possible. I don't understand why self.forget_me would throw an error skipping execution below.

[Ray Luo (rayluo)]

what if broker sign out also throws an unexpected exception? Is this possible.

It is always possible for any code path to potentially throw an exception. And we can let those really unexpected exceptions bubble up.

I don't understand why self.forget_me would throw an error skipping execution below.

In that referenced Azure CLI's case, they persist the MSAL Python's token cache on disk, and the forget_me() operation would attempt removing some tokens thus modifying that token cache file. Again, any code path could throw exception, in this case, it can be disk I/O error.

[Jiashuo Li (jiasli)]

Thanks for the attempt to solve Azure/azure-cli#20231 (comment).

However, I don't think this change makes any difference as OSError: [WinError -2146893813] is thrown when get_accounts() is called. We won't even be able to retrieve the account that can be passed to remove_account(), because the account information is also in msal_token_cache.bin.

In other word, if msal_token_cache.bin can't be accessed, we totally lose track of what accounts are in WAM.

[Jiashuo Li (jiasli)]

Let's rethink about it.