Fix incorrect arc detection and add test cases - #763
Closed
Ray Luo (rayluo) wants to merge 2 commits into
Closed
Conversation
Robbie-Microsoft
approved these changes
Oct 31, 2024
Avery-Dunn
approved these changes
Oct 31, 2024
Contributor
Author
|
Shipped as a preview in TestPyPI. You can install it by following its instruction. |
This was referenced Nov 6, 2024
Merged
Contributor
Author
|
Fixed by e9b3913 (The unnecessary second commit in this PR's history ended up preventing this PR being marked as "merged".) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out, the previous #731 had an extra "/var" in the detection, and that causes bug #762 .
This PR will fix #762.