Change the value of "x-client-os" header - #844
Closed
Kevin Tong (tongyuze) wants to merge 1 commit into
Closed
Conversation
Ray Luo (rayluo)
suggested changes
Aug 8, 2025
Ray Luo (rayluo)
left a comment
Ray Luo (rayluo)
left a comment
Contributor
There was a problem hiding this comment.
Stakeholders discussed offline and are evaluating alternative options. So, I am leaving a Request Changes review here for now, so that my other teammates will not merge this PR as-is.
Contributor
|
Summary of the offline discussion.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eSTS expects we send x-client-os: Windows instead of win32 as there are no OS called win 32. win32 is not a recognized OS string in the current server-side platform detection logic.