Skip to content

Remove redundant GitHub Actions unit-test job - #942

Merged
gladjohn merged 2 commits into
devfrom
copilot/remove-ci-job-from-actions
Jul 10, 2026
Merged

Remove redundant GitHub Actions unit-test job#942
gladjohn merged 2 commits into
devfrom
copilot/remove-ci-job-from-actions

Conversation

Copilot AI commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The GitHub Actions PR workflow was still running the full Python 3.9–3.14 unit-test matrix even though that coverage now lives in the IDDP/ADO PR pipeline. This trims the workflow down to build/package verification only while keeping PR coverage for sdist/wheel creation and twine check.

  • Workflow scope

    • Renamed .github/workflows/python-package.yml from Build and Unit Tests to Build
    • Updated the header comment to reflect build-only responsibility
    • Clarified that unit tests, E2E, benchmarks, and SDL run in the IDDP/ADO pipeline

  • GitHub Actions job cleanup

    • Removed the ci job entirely
    • Kept the existing build job unchanged:
      • python -m build --sdist --wheel
      • twine check
      • artifact upload
    • Preserved the existing pull_request trigger with no branch filter

  • Related documentation alignment

    • Updated .Pipelines/CI-AND-RELEASE-PIPELINES.md to describe GitHub Actions as PR build verification only
    • Updated doc/python_version_support_policy.md so the supported-Python test matrix now points to the ADO pipeline files rather than the removed GitHub Actions pytest matrix
name: Build

on:
  pull_request:

jobs:
  build:
    name: Build package (sdist + wheel)

Copilot AI requested review from Copilot and removed request for Copilot July 10, 2026 17:25
Copilot AI requested review from Copilot and removed request for Copilot July 10, 2026 17:29
Copilot AI changed the title [WIP] Remove redundant unit testing from GitHub Actions Remove redundant GitHub Actions unit-test job Jul 10, 2026
Copilot AI requested a review from gladjohn July 10, 2026 17:30
@gladjohn
gladjohn marked this pull request as ready for review July 10, 2026 17:49
@gladjohn
gladjohn requested a review from a team as a code owner July 10, 2026 17:49
Copilot AI review requested due to automatic review settings July 10, 2026 17:49
Copilot AI reviewed Jul 10, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s CI documentation and GitHub Actions PR workflow to reflect that unit/E2E/benchmark/SDL validation now happens in the IDDP/ADO pipelines, leaving GitHub Actions responsible only for PR-time package build and distribution metadata verification.

Changes:

  • Removed the GitHub Actions unit-test matrix job, keeping only python -m build + twine check + artifact upload.
  • Renamed the GitHub Actions workflow from “Build and Unit Tests” to “Build” and updated its header comment to match build-only scope.
  • Updated pipeline/version-support documentation to point Python version test-matrix ownership to ADO pipeline files.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
doc/python_version_support_policy.md Repoints “supported Python versions encoded in…” references from GitHub Actions to ADO pipeline files.
.Pipelines/CI-AND-RELEASE-PIPELINES.md Updates narrative to describe GitHub Actions as PR package build verification (build + twine check) only.
.github/workflows/python-package.yml Renames workflow and removes the unit-test matrix job, preserving build/package verification steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread doc/python_version_support_policy.md
@gladjohn
gladjohn merged commit 8ca3c3a into dev Jul 10, 2026
8 checks passed
Robbie-Microsoft added a commit that referenced this pull request Jul 30, 2026
@Robbie-Microsoft
Merge origin/dev into sni-mtls-pop (resync #938 with base)
4ec592f 
Bring the SNI mTLS PoP branch current with base dev (which had advanced with
PRs #911, #937, #940, #942), resolving the acquire_token_for_client overlap
between this branch's mtls_proof_of_possession feature and dev's new
forwarded_client_claims parameter (#937).

Conflicts resolved by integrating BOTH sides:
- msal/application.py acquire_token_for_client(): keep both the
  mtls_proof_of_possession and forwarded_client_claims parameters, both request
  setup blocks, and the fail-closed mtls_pop downgrade/binding_certificate
  post-processing (result = _clean_up(...) form).
- msal/application.py _acquire_token_for_client(): keep the is_mtls_pop client
  selection AND the client_claims merge into the OAuth claims parameter; the
  single popped request_data carries token_type/key_id and client_claims on the
  wire.
- tests/test_token_cache.py: union the imports (_key_id_to_str from this branch
  plus _parse_claims_or_raise/_merge_claims from dev).

No Task-1 SNI hardening dropped: the mTLS PoP feature, the
test_credential_x509_output_{pop,bearer} matrix, the region split (pop GLOBAL /
bearer REGIONAL westus3, no regional pop cell), the _call_graph helper, and the
downgrade fail-closed all remain. No escape hatch reintroduced.

Verified: py_compile clean; pytest collects 196 tests (e2e matrix + upstream
suites); 17 mtls_pop + forwarded_client_claims unit tests pass; 49 token_cache
tests pass.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Robbie-Microsoft added a commit that referenced this pull request Jul 30, 2026
@Robbie-Microsoft
Merge resync'd #938 (origin/dev) into FIC branch #939
09e8fb5 
Bring the FIC branch current with base dev by merging the resync'd SNI branch
(rginsburg/sni-mtls-pop @ 4ec592f, which merged origin/dev), so #939 also
carries PRs #911, #937, #940, #942.

Single conflict in msal/application.py acquire_token_for_client(), resolved by
integrating BOTH sides: keep the FIC-aware mTLS condition
(mtls_proof_of_possession or self._mtls_is_fic_leg2) and its comment from this
branch, AND add dev's forwarded_client_claims request-setup block above it. The
private _acquire_token_for_client() auto-merged correctly, combining the
FIC/mtls client selection (is_mtls_pop or self._mtls_is_fic_leg2) with dev's
client_claims -> OAuth claims merge.

The FIC e2e test test_fic_two_leg_over_mtls_pop and its leg-1 skip-hatch are
left UNTOUCHED (de-hatch + resource-call port + Credential_Fic_Output_* naming
remain Task 2). Region split, x509 pop/bearer matrix, and downgrade fail-closed
are all preserved.

Verified: py_compile clean; e2e matrix (pop/bearer) + FIC test collect; 22
mtls_pop + forwarded_client_claims unit tests pass.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@trwalke trwalke trwalke approved these changes
@Avery-Dunn Avery-Dunn Avery-Dunn approved these changes
@gladjohn gladjohn Awaiting requested review from gladjohn
+1 more reviewer
@RyAuld RyAuld RyAuld approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gladjohn gladjohn

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@trwalke @Avery-Dunn @RyAuld @gladjohn