Fix volunteer spreadsheet tests for term and senior results#1769
Open
BhushanSah wants to merge 1 commit into
Open
Fix volunteer spreadsheet tests for term and senior results#1769BhushanSah wants to merge 1 commit into
BhushanSah wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
The spreadsheet CI tests were failing because the expected test output no longer matched the current spreadsheet behavior.
getUniqueVolunteers()now returns aTermcolumn, but the test still expected onlyFull Name,Email, andB-Number.graduatingSeniorsVolunteerHours()can also return existing senior records from the database, so the test should not expect the entire result list to be empty or only contain the test-created users.Changes
test_getUniqueVolunteersto include theTermcolumn in the expected output.test_graduatingSeniorsVolunteerHoursto check for specific test users instead of assuming the full result list is empty.Testing