Add TAB-hold shortcuts menu - #389
Merged
Merged
Conversation
Pressing TAB shows a context-aware overlay with keyboard shortcuts: - Main menu (connected): V to join from clipboard, J to join lobby, C to create lobby - Main menu (in lobby): C to copy code, V to view code, L to leave - Main menu (disconnected): R to reconnect - In-game (in lobby): C to copy code, I for lobby info Shortcuts can be triggered by pressing the key while TAB is held, or by clicking the shortcut row. Menu dismisses on TAB release. https://claude.ai/code/session_014FaSJ5FwuXMfcUmM5Hiy81
…shortcut - Replace duplicate b_sc_* keys with existing b_copy_code, b_view_code, b_join_lobby, b_create_lobby, b_leave_lobby, b_reconnect, b_lobby_info - Re-add View Code shortcut using existing b_view_code - Add Choose Deck/Stake shortcut (D key), gated on host or different_decks - Only new loc keys: k_sc_title, k_sc_hint, b_sc_choose_deck
lobby_choose_deck passes its argument to vanilla setup_run which indexes e.config. Pass a stub UI element table to avoid nil index.
No need for lobby code or lobby info shortcuts during gameplay.
stephenkirk
added a commit
that referenced
this pull request
Apr 16, 2026
* Add TAB-hold shortcuts menu for quick multiplayer actions Pressing TAB shows a context-aware overlay with keyboard shortcuts: - Main menu (connected): V to join from clipboard, J to join lobby, C to create lobby - Main menu (in lobby): C to copy code, V to view code, L to leave - Main menu (disconnected): R to reconnect - In-game (in lobby): C to copy code, I for lobby info Shortcuts can be triggered by pressing the key while TAB is held, or by clicking the shortcut row. Menu dismisses on TAB release. https://claude.ai/code/session_014FaSJ5FwuXMfcUmM5Hiy81 * Adjust shortcuts menu overlay: 40% opacity, left-aligned positioning * Reuse existing localization keys for shortcuts menu, add deck picker shortcut - Replace duplicate b_sc_* keys with existing b_copy_code, b_view_code, b_join_lobby, b_create_lobby, b_leave_lobby, b_reconnect, b_lobby_info - Re-add View Code shortcut using existing b_view_code - Add Choose Deck/Stake shortcut (D key), gated on host or different_decks - Only new loc keys: k_sc_title, k_sc_hint, b_sc_choose_deck * Fix crash when opening deck picker from shortcuts menu lobby_choose_deck passes its argument to vanilla setup_run which indexes e.config. Pass a stub UI element table to avoid nil index. * Remove in-game shortcuts from TAB menu No need for lobby code or lobby info shortcuts during gameplay. --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan