Fix matching skip timer: use max instead of abs - #523
Merged
Conversation
math.abs gave both players bonus time based on the skip difference, meaning the player who skipped less also got extra time from their opponent's skips. Changed to math.max(..., 0) so only the player with more skips gets the bonus, and the player with fewer skips sees no change. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MuDBRvAF5nx9htEHCW2WqZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
math.absinupdate_matching_skip_timergave both players bonus time based on the skip difference — meaning the player who skipped less also got extra time from their opponent's skips. Changed tomath.max(..., 0)so only the player with more skips gets the bonus, and the player with fewer skips sees no timer change.Generated by Claude Code