Merged
Conversation
Had to fix some bugs with the attributes in the `Verb` class Reordered arguments in the `Tag` class to match `Verb`
brianluisgomez
approved these changes
Sep 28, 2022
ajrice6713
added a commit
that referenced
this pull request
Sep 29, 2022
* DX-2870 Create Base BXML Classes Created base class for root (`<Bxml>` and `<Response>`) Created base class for verbs Wrote `<Tag>` verb to do some basic testing * Add docstrings * Refactor `BxmlRoot` -> `Root` `BxmlVerb` -> `Verb` * Refactor tests for bxml base classes * Add `test_tag.py` to test `<Tag>` Also fixed some bugs in the base models causing test failures * Clean up tests to follow proper pytest convention Removed `lxml` from requirements Added base class tests * Add another test to add verbs during init of root * DX-2901, DX-2908, DX-2918 (#114) * DX-2901 `<PhoneNumber>` BXML Had to fix some bugs with the attributes in the `Verb` class Reordered arguments in the `Tag` class to match `Verb` * DX-2908 Refactor `<SipUri> BXML * DX-2918 Refactor `<Transfer>` BXML * Cleanup and update descriptions in docstrings * Fix WebRTC Utilities Test * import List type for Python < 3.9 https://stackoverflow.com/a/63460173/11633328 * Fix other `List` instances * Missed one `List` * Add `Union` to support multiple types in List * Construct verbs in alphabetical order to satisfy python@3.7 tests * Alphabetize attributes dict for python3.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following BXML Verbs
<Transfer><SipUri><PhoneNumber>Fixes WebRTC Utilities Module and Tests