DX-2887 Create <Bridge> BXML
#116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpateldx
requested changes
Sep 30, 2022
bandwidth/model/bxml/verbs/bridge.py
Outdated
| nested_verbs=None | ||
| ) | ||
|
|
||
| def add_verb(self, verb: Verb): |
There was a problem hiding this comment.
Another option - create a subclass of Verb(ex. TerminalVerb or LeafVerb) and implement this method in it. Actually this subclass can then have any specific characteristics of leaf/terminal Verb, not just disallowing adding child Verb As long as the inheritance chain is not more than three or so classes it would be maintainable and easy to understand.
brianluisgomez
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.