DX-2855 Update BXML library#133
Merged
ajrice6713 merged 9 commits intofeature/openapi-generator-sdkfrom Oct 18, 2022
Merged
Conversation
ajrice6713
changed the base branch from
main
to
feature/openapi-generator-sdk
brianluisgomez
approved these changes
Oct 13, 2022
ckoegel
approved these changes
Oct 14, 2022
bpateldx
requested changes
Oct 14, 2022
test/unit/bxml/test_conference.py
Outdated
| expected = '<Conference mute="true" hold="false" callIdsToCoach="example-call-id" conferenceEventUrl="example.com/eventurl" conferenceEventMethod="POST" conferenceEventFallbackUrl="backupexample.com/eventurl" conferenceEventFallbackMethod="POST" username="user" password="pass" fallbackUsername="user" fallbackPassword="pass" tag="tag" callbackTimeout="5">conf1<PlayAudio>https://audio.url/audio1.wav</PlayAudio><StartRecording recordingAvailableUrl="example.com" recordingAvailableMethod="POST" username="user" password="pass" tag="tag" fileFormat="wav" multiChannel="true" /><SpeakSentence>Hello there.</SpeakSentence></Conference>' | ||
| self.conference.add_verb(self.speak_sentence) | ||
| assert(expected == self.conference.to_bxml()) | ||
| with pytest.raises(AttributeError): |
There was a problem hiding this comment.
Your Test could follow same structure as your code in a way, that is, just like add_verb is only implemented in parent class TerminalVerb the test for it can be moved to a parent Test class TerminalVerbBaseTestCase removing Test duplication. Makes sense?
Contributor
Author
There was a problem hiding this comment.
Yes - great idea. Will reduce a lot of repeated tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.