Skip to content

SWI-1997 Strip _ from BXML keys that are reserved #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajrice6713 merged 1 commit into from
Mar 31, 2023
Merged

SWI-1997 Strip _ from BXML keys that are reserved #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bandwidth/model/bxml/verb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def _set_attributes(self, root: ET.Element):
if self._attributes is not None:
for key, value in self._attributes.items():
if value is not None:
root.set(key, value)
root.set(key.strip("_"), value)

def _to_etree_element(self) -> ET.Element:
"""Generate an ET.Element object from a Verb Object
Expand Down
2 changes: 1 addition & 1 deletion test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
pytest-cov>=2.8.1
pyhamcrest>=2.0.3
pyhamcrest>=2.0.4
2 changes: 1 addition & 1 deletion test/unit/bxml/test_forward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ def setUp(self):
self.test_verb = Verb(tag="test")

def test_to_bxml(self):
expected = '<Forward to="19195554321" _from="19195554322" callTimeout="15" diversionTreatment="propagate" diversionReason="away" uui="93d6f3c0be5845960b744fa28015d8ede84bd1a4;encoding=base64,asdf;encoding=jwt" />'
expected = '<Forward to="19195554321" from="19195554322" callTimeout="15" diversionTreatment="propagate" diversionReason="away" uui="93d6f3c0be5845960b744fa28015d8ede84bd1a4;encoding=base64,asdf;encoding=jwt" />'
assert(expected == self.forward.to_bxml())