DX-2691 messages_api Integration Tests#91
Merged
ckoegel merged 17 commits intofeature/openapi-generator-sdkfrom Aug 3, 2022
Merged
DX-2691 messages_api Integration Tests#91ckoegel merged 17 commits intofeature/openapi-generator-sdkfrom
messages_api Integration Tests#91ckoegel merged 17 commits intofeature/openapi-generator-sdkfrom
Conversation
ajrice6713
requested changes
Jul 18, 2022
Co-authored-by: AJ Rice <53190766+ajrice6713@users.noreply.github.com>
…n-sdk into DX-2691-messages
ajrice6713
approved these changes
Jul 21, 2022
bpateldx
requested changes
Jul 25, 2022
bpateldx
left a comment
bpateldx
left a comment
There was a problem hiding this comment.
Mostly looks good, please review comments on changes requested.
| "enum": [ | ||
| "DEFAULT", | ||
| "HIGH" | ||
| "default", |
Contributor
Author
There was a problem hiding this comment.
I'm not sure what you mean, the API currently returns these in lowercase
| self.assertIsInstance(message.message_direction, ListMessageDirectionEnum) | ||
| self.assertTrue(message.message_id) | ||
| self.assertIsInstance(message.message_status, MessageStatusEnum) | ||
| self.assertIsInstance(message.message_type, MessageTypeEnum) |
There was a problem hiding this comment.
Same as above, check values as it won't be dynamic.
Contributor
Author
There was a problem hiding this comment.
This probably won't be dynamic, but we can't guarantee what message comes first in the list, since this is listing all outbound messages on account.
ckoegel
commented
Jul 27, 2022
ajrice6713
approved these changes
Aug 1, 2022
brianluisgomez
approved these changes
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.