DX-2686 Add Media Integration Tests #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added FIxtures
github actions runId is not unique
bpateldx
requested changes
Jul 18, 2022
bpateldx
left a comment
bpateldx
left a comment
There was a problem hiding this comment.
Please review. No blocker except using with for opening file
test/integration/test_media_api.py
Outdated
|
|
||
| def _steps(self) -> None: | ||
| for name in dir(self): # dir() result is implicitly sorted | ||
| if name.startswith("step"): |
There was a problem hiding this comment.
Alternate way to go about finding functions you are interested in - override dir:
def __dir__(self):
# this allows naming your functions the way you really want-:)
return['upload', 'download', 'delete', 'list_media']
Contributor
Author
There was a problem hiding this comment.
dir() in python returns the list sorted in alphabetic order so i don't think this is possible (with overriding __dir__ at least - it might be possible another way
There was a problem hiding this comment.
The above function will return list so the items would be exactly in the specified order.
Simple way to go about this would be literally calling these functions in the order you desire. It will depict the intention in simple, easy to digest way.
ckoegel
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.