Update module refs to extracted package namespaces#462
Merged
Conversation
Core modules (db, customer_service, maintenance, referrals, sitemap, storage) need LayoutWrapper.app_layout in their templates because auto-layout only applies to extracted external packages, not core modules bundled in :phoenix_kit.
- Replace PhoenixKit.Modules.Billing.* with PhoenixKitBilling.* in: - integration.ex (user billing profile routes) - auth.ex (billing profile schema reference) - country_data.ex (IbanData alias) - Billing package provides compat aliases for backward compatibility
Replace old namespace references in integration.ex, auth files, and sitemap modules to use the new PhoenixKitEcommerce namespace from the extracted ecommerce package. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PhoenixKit.Modules.Shop.*references toPhoenixKitEcommerce.*in integration.ex, auth files, and sitemap modulesPhoenixKit.Modules.Billing.*references toPhoenixKitBilling.*namespaceChanges
Module namespace migration
lib/phoenix_kit_web/integration.ex— Shop refs → PhoenixKitEcommercelib/phoenix_kit/users/auth.ex— Shop.Cart → PhoenixKitEcommerce.Cartlib/phoenix_kit_web/users/auth.ex— Shop → PhoenixKitEcommercelib/modules/sitemap/sources/shop.ex— alias PhoenixKitEcommerce, as: Shoplib/modules/sitemap/sources/router_discovery.ex— PhoenixKitEcommercelib/modules/sitemap/web/settings.ex— PhoenixKitEcommerceOther
Test plan
mix compilepasses with 0 errorsmix credo --strictpassesmix dialyzerpasses🤖 Generated with Claude Code