Fix #2919: extra blank line in confirmation conversation prompts#2927
Merged
tastybento merged 1 commit intodevelopfrom Apr 8, 2026
Merged
Fix #2919: extra blank line in confirmation conversation prompts#2927tastybento merged 1 commit intodevelopfrom
tastybento merged 1 commit intodevelopfrom
Conversation
Conversation prompts were sending their text via User.sendRawMessage and returning "" from getPromptText, which caused Bukkit's Conversation API to print an empty line after the actual prompt. Return the legacy-coded translation directly instead — Paper renders § codes correctly through sendRawMessage, so the original workaround is no longer needed. Reverts the prompt-rendering portion of 515a7f1 across all 9 prompt classes (ConfirmPrompt, admin/blueprint NamePrompt, InviteNamePrompt, Commands/Description/Name(Success)Prompt) and restores the matching test assertions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/ob settings→ Reset to default) printed an extra blank line above the prompt text.Player.sendRawMessageformatting path by sending the prompt viaUser.sendRawMessageand returning""fromgetPromptText. Bukkit's Conversation API still prints whatevergetPromptTextreturns, so the empty string became a blank chat line.§-coded translation directly fromgetPromptTextrenders correctly, so the workaround is no longer needed. Reverts the prompt-rendering portion of 515a7f1 across all 9 prompt classes (ConfirmPrompt, admin/blueprintNamePrompt,InviteNamePrompt, blueprintCommands/Description/Name(Success)Prompt) and restores the matching test assertions inIslandTeamInviteGUITestandCommandsPromptTest.PanelItemBuildermulti-line name change from 515a7f1 is not touched.Test plan
./gradlew test --tests "*ConfirmPrompt*" --tests "*IslandTeamInviteGUITest*" --tests "*CommandsPromptTest*" --tests "*NamePrompt*"— green/ob settings→ Reset to default — prompt renders with colors and no blank line (confirmed by reporter scenario)/island team invitename entry prompt/island renamehomeprompt/bbox blueprintadmin name / description / commands edit flows (the most format-heavy prompts)