Preserve addon placeholders across /bbox reload (#2930)#2931
Merged
tastybento merged 1 commit intodevelopfrom Apr 9, 2026
Merged
Preserve addon placeholders across /bbox reload (#2930)#2931tastybento merged 1 commit intodevelopfrom
tastybento merged 1 commit intodevelopfrom
Conversation
The reload command was wiping every registered placeholder via PlaceholderAPIHook.unregisterAll(), but only re-registered the gamemode-default ones afterwards. Addons are not actually disabled by reload, so addon-registered placeholders (e.g. %level_..._island_level% from the Level addon) were left as orphaned, empty entries inside cached AddonPlaceholderExpansion instances and silently stopped resolving. Narrow PlaceholderAPIHook.unregisterAll() to only clear the BentoBox core expansion, add a targeted unregisterAll(Addon) overload, and have BentoBoxReloadCommand clear only the gamemode addons it knows how to rebuild. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
%level_aoneblock_island_level%silently stop resolving after/bbox reload.BentoBoxReloadCommandwas callingPlaceholderAPIHook.unregisterAll(), which wiped every registered placeholder including ones owned by third-party addons. The reload then only re-registered gamemode-default placeholders, so addon expansions were left cached with empty maps andonPlaceholderRequestreturnednull. Addons are not actually disabled by reload, so their replacers were still valid — they were just thrown away.PlaceholderAPIHook.unregisterAll()to only clear the BentoBox-core expansion, add a targetedunregisterAll(Addon)overload, and have the reload command clear only the gamemode addons it knows how to rebuild.Test plan
./gradlew test --tests "world.bentobox.bentobox.managers.PlaceholdersManagerTest"%level_aoneblock_island_level%in tab/scoreboard, run/bbox reload, confirm the placeholder still resolves.🤖 Generated with Claude Code