Skip to content

Don't clear gamemode addon placeholders on reload (#2930 follow-up) #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tastybento merged 1 commit into from
Apr 9, 2026
+6 −4
Merged

Don't clear gamemode addon placeholders on reload (#2930 follow-up) #2932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/main/java/world/bentobox/bentobox/commands/BentoBoxReloadCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,14 @@ public boolean execute(User user, String label, List<String> args) {
if (args.isEmpty()) {
this.askConfirmation(user, user.getTranslation("commands.bentobox.reload.warning"), () -> {

// Clear placeholders that this reload will rebuild. Addon-owned
// placeholders (e.g. from the Level addon) are intentionally
// preserved because reload does not re-invoke addons (#2930).
// Clear only BentoBox-core placeholders. Addon-owned placeholders
// (both gamemode defaults and any custom ones addons register
// themselves) are intentionally preserved because reload does
// not re-invoke addons (#2930). registerDefaultPlaceholders
// below is idempotent, so any newly-added flag placeholders
// will still be picked up.
PlaceholdersManager pm = getPlugin().getPlaceholdersManager();
pm.unregisterAll();
getPlugin().getAddonsManager().getGameModeAddons().forEach(pm::unregisterAll);

// Close all open panels
PanelListenerManager.closeAllPanels();
Expand Down
Loading