Merged
Conversation
Adds Flag.Builder.minimumRank(int) so addons can declare a minimum selectable rank for a PROTECTION flag (default VISITOR_RANK). The auto-assigned CycleClick listener is wired with the configured minimum so the click cycle skips ranks below it. defaultRank is clamped up to minimumRank to keep the flag's default value selectable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Flag.Builder.minimumRank(int)lets addons declare the lowest rank that may be selected for aPROTECTIONflag (defaultVISITOR_RANK, so fully backwards-compatible).CycleClicklistener is now constructed with the configured minimum, so the click-cycle in the settings panel will not let players select ranks below it (e.g. setminimumRank(MEMBER_RANK)to restrict a flag to Member/Sub-owner/Owner).build()clampsdefaultRankup tominimumRank(with a logged warning) so a misconfigured flag still has a selectable default.Flag.getMinimumRank()andFlag.getClickHandler()getters.Test plan
./gradlew test --tests "world.bentobox.bentobox.api.flags.*"— all greenFlagTest:minimumRankisVISITOR_RANKBuilder.minimumRank(MEMBER_RANK)is reflected on the built flagCycleClickcarries the configured minimum (verified via reflection on the listener'sminRankfield)defaultRankbelowminimumRankis clamped upNotes
CycleClick— the existing two-arg constructor and rank-bound enforcement inleftClick/rightClickalready handle this; the Builder just exposes it.🤖 Generated with Claude Code