GraphicsSettings - Do not override by default, remember game defaults#4
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the GraphicsSettings plugin to not override graphics settings by default and instead remember the game's original settings. The main change shifts from forcing specific graphics values to allowing users to optionally override them while preserving the original game configuration.
- Changed default behavior to preserve game defaults instead of forcing specific values
- Added ability to capture and restore original graphics settings (resolution, display mode, vsync)
- Improved scene change event handling with fallback mechanisms for better compatibility
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| GraphicsSettingsIL2CPP_netFm/GraphicsSettings.cs | Updated GUID and implemented new default-preserving graphics settings logic |
| GraphicsSettingsIL2CPP_net6/GraphicsSettings.cs | Implemented identical default-preserving graphics settings logic for .NET 6 version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.