Skip to content

GraphicsSettings - Do not override by default, remember game defaults#4

Merged
ManlyMarco merged 1 commit into
mainfrom
grap-upd
Oct 1, 2025
Merged

GraphicsSettings - Do not override by default, remember game defaults#4
ManlyMarco merged 1 commit into
mainfrom
grap-upd

Conversation

@ManlyMarco
Copy link
Copy Markdown
Member

No description provided.

@ManlyMarco ManlyMarco requested a review from Copilot October 1, 2025 02:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the GraphicsSettings plugin to not override graphics settings by default and instead remember the game's original settings. The main change shifts from forcing specific graphics values to allowing users to optionally override them while preserving the original game configuration.

  • Changed default behavior to preserve game defaults instead of forcing specific values
  • Added ability to capture and restore original graphics settings (resolution, display mode, vsync)
  • Improved scene change event handling with fallback mechanisms for better compatibility

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
GraphicsSettingsIL2CPP_netFm/GraphicsSettings.cs Updated GUID and implemented new default-preserving graphics settings logic
GraphicsSettingsIL2CPP_net6/GraphicsSettings.cs Implemented identical default-preserving graphics settings logic for .NET 6 version

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread GraphicsSettingsIL2CPP_netFm/GraphicsSettings.cs
Comment thread GraphicsSettingsIL2CPP_netFm/GraphicsSettings.cs
Comment thread GraphicsSettingsIL2CPP_net6/GraphicsSettings.cs
Comment thread GraphicsSettingsIL2CPP_net6/GraphicsSettings.cs
Comment thread GraphicsSettingsIL2CPP_netFm/GraphicsSettings.cs
Comment thread GraphicsSettingsIL2CPP_net6/GraphicsSettings.cs
@ManlyMarco ManlyMarco merged commit 87a36d9 into main Oct 1, 2025
@ManlyMarco ManlyMarco deleted the grap-upd branch October 1, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants