comparison: schema_versions without the 1.x safeguards#73
Closed
effron wants to merge 2 commits into
Closed
Conversation
…eguards) Comparison-only variant of the schema_versions change with zero compatibility machinery: no serializer-version guards on read, no hybrid or empty-list detection, no schema upgrade command, no UPGRADING.md. Assumes every binary and every repo cut over to v2 simultaneously. BREAKING CHANGE: serializer_version bumps to 2 with no conversion or detection path from v1. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
closing in favor of #74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparison artifact for #71 -- not for merge.
This is the same schema_versions change with every 1.x safeguard deleted: no serializer-version guards on read, no hybrid or empty-list detection, no
schema upgradecommand, no UPGRADING.md. It assumes every binary and every repo cuts over to v2 at the same instant.The size difference is the cost of coexisting with 1.x: +248 lines here vs +855 on #71 (and about half of #71's extra bulk is tests for the failure modes this branch pretends don't exist).
What this version does when the cut-over assumption fails, all reproduced with a real 1.9 binary while building #71:
serializer_version: 2; this version reads that file without complaintschema generatefails there; withoutschema upgradethose apps simply can't adopt v2)Useful as a reference for which lines exist for the migration story vs the feature itself.