Fix SortAlphabetically's remote-kill comparator#75
Draft
effron wants to merge 1 commit into
Draft
Conversation
The two-key comparison (Split < Split && Reason < Reason) is not a strict weak ordering, so remote_kills order in the written schema depended on input order — a source of spurious diffs on every schema write. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
claude did this, making sure it's real before taking out of draft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two-key comparison (
Split < Split && Reason < Reason) is not a strict weak ordering, so remote_kills order in the written schema depended on input order -- with mutually incomparable kills,sort.Sliceproduces different output for different input orders, causing spurious diffs on schema writes. Standard two-key tiebreak fixes it; test covers the incomparable case.Found while working on #74.