fix(ui): correct file:disabled variant order so the dev server compiles#1026
Conversation
… globals.css The file input in DocumentManagerPanel used `file:disabled:opacity-50`, which Tailwind expands to `::file-selector-button:disabled` — a pseudo-class after a pseudo-element. Only user-action pseudo-classes (:hover/:active/:focus) are valid there, so Next 16's Turbopack CSS parser rejects the generated rule and fails to compile globals.css, 500-ing every route in `npm run dev` / `npm run ensure` / `verify:ui` (the production Lightning CSS build tolerated it, so deploys were unaffected). Reorder to `disabled:file:opacity-50`, which generates the valid `:disabled::file-selector-button` (pseudo-class before pseudo-element) and keeps the intent: dim the file-picker button while the input is disabled. Verified: `npm run dev` now compiles (Ready in 2.6s); `/`, the documents/upload surface, and other routes return 200 with no CSS parse error. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019g9m5emoPKCmDDPeGrchYd
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PDF upload input’s Tailwind disabled-opacity class variant order was updated in ChangesUpload input styling
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
DocumentManagerPanelusedfile:disabled:opacity-50. Tailwind expands that to::file-selector-button:disabled— a pseudo-class after a pseudo-element, which is invalid CSS (only user-action pseudo-classes like:hover/:active/:focusare allowed there).globals.css, which 500-ed every route undernpm run dev/npm run ensure/npm run verify:ui. (The production Lightning CSS build tolerated it, so deploys and theBuildCI job were unaffected — this was dev/UI-verification only.)disabled:file:opacity-50, which generates the valid:disabled::file-selector-button(pseudo-class before pseudo-element) and preserves the intent — dim the file-picker button while the input is disabled.One-line change:
Verification
npm run devnow compiles — Ready in 2.6s (previously hung / 500-ed on the CSS parse error)/,/mockups/patient-safety-plan, and/api/local-project-idall return HTTP 200, noParsing CSS source code failedin the dev logtsc --noEmit) — cleaneval:*,check:production-readinessRisk and rollout
Clinical Governance Preflight
CSS-only styling fix on an existing control; no ingestion, answer generation, retrieval/ranking, source rendering, document-access, privacy, production-env, or clinical-output behaviour is touched — all items below hold unchanged.
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
npm run dev/verify:uifor everyone on the Next 16 + Tailwind v4 setup.🤖 Generated with Claude Code
https://claude.ai/code/session_019g9m5emoPKCmDDPeGrchYd
Generated by Claude Code
Summary by CodeRabbit