refactor(frontend): tokenize the shell-header viewport offset (--shell-header-h)#1038
Conversation
Replace the duplicated `calc(100dvh - 4rem)` app-shell-height literal (~13 production files + therapy-compass.css) with a single `--shell-header-h: 4rem` token, so the header height and the page-fill floors below it cannot silently drift apart (RESP-01/DSD-04). The token value equals the literal it replaces, so computed heights are byte-identical — no visual change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 19 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
1 participant
Summary
Follow-up to #1036. Replaces the duplicated
calc(100dvh - 4rem)app-shell/header-height literal with a single--shell-header-h: 4remtoken across ~13 production files +therapy-compass.css, so the header height and the page-fill floors below it (calc(100dvh - var(--shell-header-h))) cannot silently drift apart. (RESP-01 / DSD-04)Zero visual change by construction: the token value equals the literal it replaces, so every computed height is byte-identical. No
capture-chrome-parityrun is required for this slice.Also updates 3 source-string-pinning assertions in
mobile-interaction-regressions.test.tsto the token form (guard intent preserved, not weakened).Scope note
Deliberately limited to the value-identical
4remshell-header offset. The rest of RESP-01 — the non-4remcomposer-dock subtrahends (11/12.5/13.5rem) and RESP-02's sticky-header top offsets (69/80/92/96px) — are not value-identical, so tokenizing them changes pixels and needs the running-server byte-parity capture; left as a documented follow-up rather than risk visual drift.Verification
npm run typecheck✓ ·npm run lint✓ · full unit+jsdom suitenpm run test— 339 files / 3065 passed / 1 skipped / 0 failed ✓ ·check:design-system-contract✓ ·format:check✓. Chromiumverify:uiruns in CI.Clinical-governance preflight
N/A — pure CSS/layout tokenization. No ingestion, answer generation, search/ranking, source rendering, document access, privacy, or clinical-output changes.
🤖 Generated with Claude Code