docs(issues): close #008 as false-positive; fix #014 broken doc path

[BigSimmo]

Summary

Docs-only ledger update resolving #8 and fixing a pre-existing broken doc link.

• Close Bump gitleaks/gitleaks-action from 2 to 3 #8 as a false positive. The ledger claimed documentReaderHref / documentEvidenceHref (+ *MockHref variants) in src/lib/document-flow-routes.ts were "exported but never called in src". They are not dead code: the mock wrappers mockDocumentReaderHref / mockDocumentEvidenceHref are used by src/components/document-search-mockups.tsx and src/components/master-document-flow-mockups.tsx (rendered by the src/app/mockups/document-search/* routes), those wrappers call the base builders (and use their Parameters<typeof …> types), and tests/document-flow-routes.test.ts covers them. Removing any of them breaks typecheck/build + a test. Moved to Resolved/archive. (The only kernel of truth — the production, non-mock /documents/source hrefs aren't linked from production UI — is a wiring gap, not dead code.)
• Fix Clean stale frontend identity and CSS #14 Source path — src/components/document-viewer/signed-image.tsx → src/components/clinical-dashboard/signed-image.tsx. The document-viewer/ path never existed, so it was failing docs:check-links on main; this repairs it.

Verification

• prettier --check docs/outstanding-issues.md ✅
• npm run docs:check-links ✅ (1092 references resolve — repairs the pre-existing Clean stale frontend identity and CSS #14 red)

Governance

• RAG impact: no retrieval behaviour change — docs-only ledger edit (no code touched).
• Clinical governance preflight: N/A — single file changed: docs/outstanding-issues.md.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Documentation
  • Updated the outstanding issues tracker to archive a resolved dead-link recommendation.
  • Documented that the related links remain required and are covered by automated tests.
  • Corrected the source path for the signed preview image optimization item.

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[coderabbitai]

📝 Walkthrough

Walkthrough

The documentation archives issue #008 with evidence that its href builders are exercised and tested, and updates issue #014 to reference the clinical-dashboard signed-image component.

Changes

Outstanding issues documentation

Layer / File(s)	Summary
Issue status and source path updates docs/outstanding-issues.md	Moves issue #008 to the resolved archive with mock-wrapper and test references, and corrects issue #014’s source path to src/components/clinical-dashboard/signed-image.tsx.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• BigSimmo/Database#686: Removes the SignedImage default export from the component referenced by issue #014.
• BigSimmo/Database#1043: Also updates the shared issue #014 documentation entry.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the docs-only ledger update: closing #008 as false-positive and fixing the broken #014 doc path.
Description check	✅ Passed	The description covers the change summary and verification, and is mostly complete despite missing the template's Risk/Rollout and Notes sections.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/close-008-false-positive

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/outstanding-issues.md`:
- Line 59: Update the `#008` entry in docs/outstanding-issues.md to use the actual
resolution or merge date instead of the future-dated 2026-07-22 value,
preserving the existing issue description and status.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 32808127-58e1-4aa6-9585-ab18cd871448

📥 Commits

Reviewing files that changed from the base of the PR and between b981caa and 5678bd4.

📒 Files selected for processing (1)

• docs/outstanding-issues.md

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect the relevant section with line numbers.
sed -n '45,75p' docs/outstanding-issues.md | cat -n

# Show the file metadata and current system date available in the sandbox.
stat -c 'mtime=%y size=%s file=%n' docs/outstanding-issues.md
date -u '+utc=%Y-%m-%d %H:%M:%S %Z'
date '+local=%Y-%m-%d %H:%M:%S %Z'

Repository: BigSimmo/Database

Length of output: 7037

---

Avoid future-dating the archive entry. docs/outstanding-issues.md:59 records #008 as resolved on 2026-07-22, which is later than this change; use the actual resolution/merge date so /issues stays historically accurate.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/outstanding-issues.md` at line 59, Update the `#008` entry in
docs/outstanding-issues.md to use the actual resolution or merge date instead of
the future-dated 2026-07-22 value, preserving the existing issue description and
status.